Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): update Facebook Login SDK for iOS #804

Merged
merged 5 commits into from
Jan 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nine-dogs-double.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@capacitor-firebase/authentication': major
---

feat: update Facebook Login SDK on iOS and Android to version `18.0.0`
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ env:
jobs:
build:
name: Build
runs-on: macos-14
runs-on: macos-15
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
run: npm run verify
lint:
name: Lint
runs-on: macos-14
runs-on: macos-15
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
4 changes: 4 additions & 0 deletions packages/authentication/BREAKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ This is a comprehensive list of the breaking changes introduced in the major ver

## Version 7.x.x

### Variables

- On Android, the `facebookLoginVersion` variable has been updated to `18.0.0`.

### Google Sign-In

On **Android**, the `accessToken` and `serverAuthCode` are now only requested when the `scopes` option is set.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Pod::Spec.new do |s|

s.subspec 'Facebook' do |facebook|
facebook.xcconfig = { 'OTHER_SWIFT_FLAGS' => '$(inherited) -DRGCFA_INCLUDE_FACEBOOK' }
facebook.dependency 'FBSDKCoreKit', '17.1.0'
facebook.dependency 'FBSDKLoginKit', '17.1.0'
facebook.dependency 'FBSDKCoreKit', '18.0.0'
facebook.dependency 'FBSDKLoginKit', '18.0.0'
end
end
2 changes: 1 addition & 1 deletion packages/authentication/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ext {
rgcfaIncludeFacebook = project.hasProperty('rgcfaIncludeFacebook') ? rootProject.ext.rgcfaIncludeFacebook : false
firebaseAuthVersion = project.hasProperty('firebaseAuthVersion') ? rootProject.ext.firebaseAuthVersion : '22.3.1'
playServicesAuthVersion = project.hasProperty('playServicesAuthVersion') ? rootProject.ext.playServicesAuthVersion : '21.0.0'
facebookLoginVersion = project.hasProperty('facebookLoginVersion') ? rootProject.ext.facebookLoginVersion : '16.3.0'
facebookLoginVersion = project.hasProperty('facebookLoginVersion') ? rootProject.ext.facebookLoginVersion : '18.0.0'
androidxCredentialsVersion = project.hasProperty('androidxCredentialsVersion') ? rootProject.ext.androidxCredentialsVersion : '1.5.0-rc01'
androidxCredentialsPlayServicesAuthVersion = project.hasProperty('androidxCredentialsPlayServicesAuthVersion') ? rootProject.ext.androidxCredentialsPlayServicesAuthVersion : '1.5.0-rc01'
librariesIdentityGoogleidVersion = project.hasProperty('librariesIdentityGoogleidVersion') ? rootProject.ext.librariesIdentityGoogleidVersion : '1.1.1'
Expand Down
4 changes: 2 additions & 2 deletions packages/authentication/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ target 'Plugin' do
capacitor_pods
pod 'FirebaseAuth', '11.0.0'
pod 'GoogleSignIn', '7.1.0'
pod 'FBSDKCoreKit', '17.1.0'
pod 'FBSDKLoginKit', '17.1.0'
pod 'FBSDKCoreKit', '18.0.0'
pod 'FBSDKLoginKit', '18.0.0'
end

target 'PluginTests' do
Expand Down