-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename error codes #805
Conversation
Add prefix to error codes.
Add prefix to error codes.
Add prefix to error codes.
Run format script.
Generate changeset.
@ebarooni Did you forgot to commit the changes for the Storage plugin or are none needed there? |
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
@robingenz No changes needed beside what is committed. In the the error handling you had already prefixed the error codes with |
@robingenz On android. And the same was in ios. Therefore no changes needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset
).Closes: #616