Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deposit deadline option #1798

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Add Deposit deadline option #1798

merged 5 commits into from
Jan 23, 2025

Conversation

v0d1ch
Copy link
Contributor

@v0d1ch v0d1ch commented Jan 21, 2025

We were re-using contestation-period value as a deposit deadline. This PR adds a separate argument to specify deposit deadline.


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@v0d1ch v0d1ch self-assigned this Jan 21, 2025
Copy link

github-actions bot commented Jan 21, 2025

Transaction cost differences

Script summary

Name Size (Bytes)
νInitial -
νCommit -
νHead -
μHead -
νDeposit -

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
44 - - - -

Commit transaction costs

UTxO Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
54 - - - -

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 - - - - -
2 - - - - -
3 - - - - -
4 - - - - -
5 - - - - -
6 - - - - -
7 - - - - -
8 - - - - -
9 - - - - -
10 - - - - -

Cost of Increment Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 - $${\color{green}-0.39}$$ $${\color{green}-0.09}$$ -
2 - $${\color{green}-0.39}$$ $${\color{green}-0.09}$$ $${\color{green}-0.01}$$
3 - $${\color{green}-0.38}$$ $${\color{green}-0.09}$$ -
5 - - - -
10 - - - -
43 - +0.39 +0.09 +0.01

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
45 - - - -

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
41 - - - -

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 - - - -
2 - - - -
3 - - - -
5 - - - -
10 - - - -
33 - - - -

FanOut transaction costs

UTxO, Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
(0, 10) - - - - -
(1, 10) - - - - -
(5, 10) - - - - -
(10, 10) - - - - -
(20, 10) - - - - -
(40, 10) - - - - -
(41, 10) - - - - -

Copy link

github-actions bot commented Jan 21, 2025

Transaction costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2025-01-23 08:52:58.798473723 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial c8a101a5c8ac4816b0dceb59ce31fc2258e387de828f02961d2f2045 2652
νCommit 61458bc2f297fff3cc5df6ac7ab57cefd87763b0b7bd722146a1035c 685
νHead 5350e9d521552ebfd9e846fd70c3b801f716fc14296134ec0fb71e97 14492
μHead 6b49dc4e571207d615dba01996548cb610b0caa85c30423d169d0091* 5612
νDeposit ae01dade3a9c346d5c93ae3ce339412b90a0b8f83f94ec6baa24e30c 1102
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per head.

Init transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 6164 10.33 3.30 0.53
2 6363 12.28 3.91 0.56
3 6567 14.24 4.52 0.59
5 6968 18.36 5.81 0.65
10 7972 29.05 9.20 0.80
44 14808 98.21 30.92 1.82

Commit transaction costs

This uses ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 561 2.44 1.16 0.20
2 739 3.38 1.73 0.22
3 917 4.36 2.33 0.24
5 1279 6.41 3.60 0.28
10 2171 12.13 7.25 0.40
54 10064 98.61 68.52 1.88

CollectCom transaction costs

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 525 24.20 7.07 0.42
2 114 636 32.08 9.36 0.50
3 171 747 43.30 12.41 0.62
4 228 858 53.48 15.23 0.73
5 284 969 55.55 16.18 0.76
6 338 1081 68.02 19.64 0.89
7 395 1192 87.00 24.55 1.08
8 453 1303 91.95 26.15 1.14
9 507 1414 88.37 25.65 1.11

Cost of Increment Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 1789 24.13 8.02 0.48
2 1970 26.48 9.50 0.52
3 2191 28.74 10.99 0.56
5 2463 31.59 13.24 0.61
10 3224 40.98 19.74 0.77
42 7895 96.01 59.32 1.70

Cost of Decrement Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 621 22.68 7.32 0.41
2 759 23.43 8.18 0.43
3 942 26.36 9.70 0.47
5 1198 28.71 11.66 0.52
10 1876 37.12 17.35 0.66
43 6985 99.35 56.82 1.67

Close transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 635 28.61 9.15 0.48
2 878 29.21 10.19 0.50
3 906 32.09 11.57 0.53
5 1186 35.59 13.99 0.59
10 2273 46.41 21.63 0.78
39 6359 98.05 57.81 1.64

Contest transaction costs

Parties Tx size % max Mem % max CPU Min fee ₳
1 674 33.31 10.41 0.52
2 823 35.29 11.69 0.56
3 937 37.21 12.94 0.59
5 1224 41.13 15.48 0.65
10 1951 52.05 22.35 0.82
30 4987 95.64 49.97 1.50

Abort transaction costs

There is some variation due to the random mixture of initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 6039 26.21 8.86 0.69
2 6180 34.72 11.75 0.79
3 6349 44.07 14.95 0.89
4 6495 53.51 18.19 1.00
5 6547 58.16 19.70 1.05
6 6752 68.51 23.26 1.17
7 6799 80.05 27.05 1.29
8 7117 88.84 30.23 1.40
9 7228 99.98 33.93 1.52

FanOut transaction costs

Involves spending head output and burning head tokens. Uses ada-only UTXO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
10 0 0 6162 19.12 6.55 0.62
10 1 57 6196 19.78 6.86 0.63
10 10 569 6501 37.98 14.16 0.85
10 20 1137 6840 55.74 21.37 1.06
10 40 2277 7522 95.45 37.32 1.52
10 42 2391 7589 99.94 39.10 1.57

End-to-end benchmark results

This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.

Please note that these results are approximate as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.

Generated at 2025-01-23 08:55:54.63763992 UTC

Baseline Scenario

Number of nodes 1
Number of txs 300
Avg. Confirmation Time (ms) 4.910850303
P99 11.275318289999992ms
P95 6.0188193000000005ms
P50 4.6644760000000005ms
Number of Invalid txs 0

Three local nodes

Number of nodes 3
Number of txs 900
Avg. Confirmation Time (ms) 21.727852461
P99 35.24020735ms
P95 28.180849849999998ms
P50 20.392763000000002ms
Number of Invalid txs 0

@v0d1ch v0d1ch force-pushed the deposit-deadline-option branch 4 times, most recently from ee20a83 to 21ef8d5 Compare January 21, 2025 19:49
@v0d1ch v0d1ch requested a review from a team January 21, 2025 19:52
@v0d1ch v0d1ch force-pushed the deposit-deadline-option branch 2 times, most recently from a3e5bfd to 3670b30 Compare January 22, 2025 10:48
Copy link

github-actions bot commented Jan 22, 2025

Test Results

  5 files  ±0  165 suites  ±0   33m 10s ⏱️ + 3m 40s
563 tests +1  561 ✅ +1  2 💤 ±0  0 ❌ ±0 
565 runs  +1  563 ✅ +1  2 💤 ±0  0 ❌ ±0 

Results for commit 933010d. ± Comparison against base commit c1c759b.

♻️ This comment has been updated with latest results.

@v0d1ch v0d1ch force-pushed the deposit-deadline-option branch from 3670b30 to 4225864 Compare January 22, 2025 16:28
@v0d1ch v0d1ch force-pushed the deposit-deadline-option branch from 4225864 to bd11e04 Compare January 22, 2025 16:50
Copy link
Contributor

@noonio noonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@v0d1ch v0d1ch added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit f339ed1 Jan 23, 2025
27 checks passed
@v0d1ch v0d1ch deleted the deposit-deadline-option branch January 23, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants