Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites issue #18 #34

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

ftp27
Copy link
Contributor

@ftp27 ftp27 commented Oct 6, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #34 into master will increase coverage by 0.67%.
The diff coverage is 73.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage    70.2%   70.88%   +0.67%     
==========================================
  Files          13       15       +2     
  Lines         443      522      +79     
==========================================
+ Hits          311      370      +59     
- Misses        132      152      +20
Impacted Files Coverage Δ
...ovieDB/Controllers/MovieDetailViewController.swift 0% <0%> (ø) ⬆️
ReduxMovieDB/Extensions/Boolean.swift 0% <0%> (ø)
ReduxMovieDB/ViewState/MovieDetailViewState.swift 100% <100%> (ø) ⬆️
...uxMovieDB/Extensions/UIImageView+MoviePoster.swift 96.72% <100%> (ø) ⬆️
...xMovieDB/Controllers/MovieListViewController.swift 87.03% <69.23%> (-2.55%) ⬇️
ReduxMovieDB/State/MainState.swift 97.05% <88.23%> (-2.95%) ⬇️
ReduxMovieDB/Storages/FavoritesStorage.swift 97.29% <97.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57d4cb...fe60b93. Read the comment docs.

@cardoso
Copy link
Owner

cardoso commented Oct 7, 2019

Hi @ftp27 ! Thanks again for your contribution! I'll review as soon as possible.

@cardoso cardoso self-requested a review October 7, 2019 13:29
@cardoso cardoso added 🎉 feature New feature or request hacktoberfest labels Oct 14, 2019
Copy link
Owner

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments:

ReduxMovieDB/Controllers/MovieListViewController.swift Outdated Show resolved Hide resolved
ReduxMovieDBTests/State/MainStateTests.swift Outdated Show resolved Hide resolved
ReduxMovieDB/Controllers/MovieDetailViewController.swift Outdated Show resolved Hide resolved
@ftp27
Copy link
Contributor Author

ftp27 commented Oct 17, 2019

It looks better now 🙂

@ftp27 ftp27 requested a review from cardoso October 17, 2019 21:25
@cardoso
Copy link
Owner

cardoso commented Oct 18, 2019

@ftp27 thank you! I'll review again as soon as possible

@squash-labs
Copy link

squash-labs bot commented Jan 17, 2023

Manage this branch in Squash

Test this branch here: https://favorites-issue-18-0jcox.squash.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants