Fix: --strategies on CLI do not seem to override disabled-strategies in the manifest

crates/bin/src/args.rs

@@ -588,9 +588,6 @@ You cannot use --{option} and specify multiple packages at the same time. Do one
                 .error(ErrorKind::TooFewValues, "You have disabled all strategies")
                 .exit()
         }
-
-        // Free disable_strategies as it will not be used again.
-        opts.disable_strategies = Vec::new();
     }
 
     // Ensure that Strategy::Compile is specified as the last strategy

crates/bin/src/entry.rs

@@ -85,7 +85,13 @@ pub fn install_crates(
         pkg_url: args.pkg_url,
         pkg_fmt: args.pkg_fmt,
         bin_dir: args.bin_dir,
-        disabled_strategies: None,
+        disabled_strategies: (!args.disable_strategies.is_empty()).then(|| {
+            args.disable_strategies
+                .into_iter()
+                .map(|strategy| strategy.0)
+                .collect::<Vec<_>>()
+                .into_boxed_slice()
+        }),
         signing: None,
     };
 

e2e-tests/manifests/strategies-test-override-Cargo.toml

@@ -0,0 +1,13 @@
+[package]
+name = "cargo-quickinstall"
+repository = "https://github.com/cargo-bins/cargo-quickinstall"
+version = "0.2.10"
+
+[[bin]]
+name = "cargo-quickinstall"
+path = "src/main.rs"
+test = false
+doc = false
+
+[package.metadata.binstall]
+disabled-strategies = ["crate-meta-data", "quick-install", "compile"]

e2e-tests/strategies.sh

@@ -37,7 +37,7 @@ fi
 ## Test compile-only strategy
 "./$1" binstall --no-confirm --strategies compile [email protected]
 
-## Test --disable-strategies
+## Test Cargo.toml disable-strategies
 set +e
 
 "./$1" binstall --no-confirm --manifest-path "manifests/strategies-test-Cargo.toml" [email protected]
@@ -49,3 +49,6 @@ if [ "$exit_code" != 94 ]; then
     echo "Expected exit code 94, but actual exit code $exit_code"
     exit 1
 fi
+
+## Test --strategies overriding `disabled-strategies=["compile"]` in Cargo.toml
+ "./$1" binstall --no-confirm --manifest-path "manifests/strategies-test-override-Cargo.toml" --strategies compile [email protected]