Simplify has_password checking in user settings

Do not use UseState for password checking and use ternary operator instead. Discussion: freeipa#375 (comment) Related to: freeipa#369 Signed-off-by: Michal Polovka <[email protected]>
carma12 · May 16, 2024 · fdefd60 · fdefd60
1 parent 3febc11
commit fdefd60
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/components/UsersSections/UsersAccountSettings.tsx b/src/components/UsersSections/UsersAccountSettings.tsx
@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
-import React, { useEffect, useState } from "react";
+import React, { useState } from "react";
 // PatternFly
 import {
   Flex,
@@ -45,12 +45,7 @@ interface PropsToUsersAccountSettings {
 
 const UsersAccountSettings = (props: PropsToUsersAccountSettings) => {
   // Use asterisks if a password is set, leave empty otherwise
-  const [password, setPassword] = useState<string>("");
-  useEffect(() => {
-    if (props.user.has_password) {
-      setPassword("********");
-    }
-  }, [props.user]);
+  const password = props.user.has_password ? "********" : "";
 
   // Get 'ipaObject' and 'recordOnChange' to use in 'IpaTextInput'
   const { ipaObject, recordOnChange } = asRecord(