Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft some missing objectives and key points #74

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

tobyhodges
Copy link
Member

After reading a comment (presumably from @ErinBecker) in the notes of a recent Maintainers meeting, I wanted to have a go at drafting the remaining LOs and key points that were missing from this curriculum. Admittedly, it has been some time since I participated in Instructor Trainer Training, so some of these may miss the mark. I will not be offended if you make significant edits or even throw them out altogether! 😆

Please note also @vasilislenis' PR #71, which you may want to review/merge before tackling this one.

Copy link

github-actions bot commented Sep 24, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/trainer-training/compare/md-outputs..md-outputs-PR-74

The following changes were observed in the rendered markdown documents:

 03_week3_discussion_questions.md   |  3 ++-
 04-week_4_discussion_questions.md  |  3 ++-
 05-week_5_discussion_questions.md  |  5 ++++-
 06-Week_6_discussion_questions.md  |  3 ++-
 09-Week_9_discussion_questions.md  |  3 ++-
 10-Week_10_discussion_questions.md |  8 ++++++--
 md5sum.txt                         | 12 ++++++------
 7 files changed, 24 insertions(+), 13 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-09-30 22:19:42 +0000

github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
@ErinBecker
Copy link
Contributor

Thanks so much for tackling this @tobyhodges! I've updated the language from "Trainers" to "Instructor Trainers" throughout for consistency (and to leave room for us to talk about Collaborative Lesson Development Trainers in other places). I've also reconciled your additions for Week 5 with those from @vasilislenis and myself.

@ErinBecker ErinBecker merged commit e5e5f1e into carpentries:main Sep 30, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
Auto-generated via {sandpaper}
Source  : e5e5f1e
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-09-30 22:20:25 +0000
Message : draft some missing objectives and key points (#74)

* draft some missing objectives and key points

* Apply suggestions from code review

Change "Trainer" to "Instructor Trainer" throughout.

* Update episodes/04-week_4_discussion_questions.md

---------

Co-authored-by: Erin Becker <[email protected]>
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
Auto-generated via {sandpaper}
Source  : 571d972
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-09-30 22:21:07 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : e5e5f1e
Branch  : main
Author  : Toby Hodges <[email protected]>
Time    : 2024-09-30 22:20:25 +0000
Message : draft some missing objectives and key points (#74)

* draft some missing objectives and key points

* Apply suggestions from code review

Change "Trainer" to "Instructor Trainer" throughout.

* Update episodes/04-week_4_discussion_questions.md

---------

Co-authored-by: Erin Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants