Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/proof parser #63

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Feature/proof parser #63

merged 7 commits into from
Sep 18, 2024

Conversation

chudkowsky
Copy link
Collaborator

@chudkowsky chudkowsky commented Sep 17, 2024

This PR is adding a proof parsing feature, changes verifier endpoint

@chudkowsky chudkowsky changed the base branch from main to feature/config September 17, 2024 16:47
Base automatically changed from feature/config to main September 17, 2024 16:48
@chudkowsky chudkowsky marked this pull request as ready for review September 17, 2024 17:20
@chudkowsky chudkowsky requested a review from piniom September 17, 2024 17:20
Copy link
Collaborator

@piniom piniom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, minor aesthetic change suggested :)))

let program_hash = extract_program_hash(stark_proof.clone());
let program_output = extract_program_output(stark_proof.clone());
let program_output_hash = program_output_hash(program_output.clone());
let prover_result = ProverResult {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we extract this to another function fo better code clarity?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@chudkowsky chudkowsky merged commit 3f2d99f into main Sep 18, 2024
4 checks passed
@chudkowsky chudkowsky deleted the feature/proof-parser branch September 18, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants