-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/proof parser #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, minor aesthetic change suggested :)))
prover/src/threadpool/prove.rs
Outdated
let program_hash = extract_program_hash(stark_proof.clone()); | ||
let program_output = extract_program_output(stark_proof.clone()); | ||
let program_output_hash = program_output_hash(program_output.clone()); | ||
let prover_result = ProverResult { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we extract this to another function fo better code clarity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
This PR is adding a proof parsing feature, changes verifier endpoint