Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomNonbondedForce #102

Merged
merged 10 commits into from
Jun 1, 2023
Merged

CustomNonbondedForce #102

merged 10 commits into from
Jun 1, 2023

Conversation

florianjoerg
Copy link
Member

@florianjoerg florianjoerg commented May 30, 2023

Description

Implement the CustomNonbondedForce
Should be done before PRs #100 and #101, because required by them

Todos

Notable points that this PR has either accomplished or will accomplish.

  • add getter and setter in residue.py
  • add implementation to _extract_templates and _create_force_idx_dict in system.py
  • add checks that other customnonbondedforces might not be covered!, maybe think of a way to generalize it(?) if possible

Status

  • Ready to go

@florianjoerg florianjoerg added enhancement New feature or request urgent labels May 30, 2023
This was referenced May 30, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #102 (2b30f91) into main (7bc986e) will increase coverage by 0.83%.
The diff coverage is 88.18%.

Additional details and impacted files

@florianjoerg florianjoerg merged commit 09f62e1 into main Jun 1, 2023
@florianjoerg florianjoerg deleted the customnonbondedforce branch June 1, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant