Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest BOR appeal data into lake #553

Merged
merged 20 commits into from
Jul 29, 2024

Conversation

wrridgeway
Copy link
Member

@wrridgeway wrridgeway commented Jul 23, 2024

ETL pipeline to take data from BOR appeals open data asset and load it into athena. Data is more-or-less unaltered. Glue crawler for the ccbor database was also added.

See #548 for more details.

As of right now using the RSocrata package (since jsonlite can't handle the amount of data being gathered from the open data portal) which needs credentials. I've added them to .Renviron, but that's a file we track with git in this repo. So we'll need to figure out a solution for this.

@wrridgeway wrridgeway self-assigned this Jul 23, 2024
@wrridgeway wrridgeway linked an issue Jul 23, 2024 that may be closed by this pull request
@wrridgeway
Copy link
Member Author

@ccao-jardine this is in athena now if you want to take a look

@wrridgeway wrridgeway marked this pull request as ready for review July 23, 2024 21:57
@wrridgeway wrridgeway requested a review from a team as a code owner July 23, 2024 21:57
@wrridgeway wrridgeway marked this pull request as draft July 24, 2024 14:10
@@ -1,6 +1,3 @@
**Primary Key**: `reascd`
{% enddocs %}

Copy link
Member Author

@wrridgeway wrridgeway Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to do with this PR, just random extraneous code that needed to be removed.

@wrridgeway wrridgeway marked this pull request as ready for review July 24, 2024 18:53
@wrridgeway wrridgeway requested a review from dfsnow July 24, 2024 18:53
@@ -0,0 +1,9 @@
# appeals

{% docs table_appeals %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Realizing that maybe we made a mistake by not prefixing these table names in the docs with their respective database, since some stuff like appeals could definitely refer to multiple tables in the future. Fine for now, but something to fix in a later PR. Can you make an issue @wrridgeway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbt/models/ccbor/docs.md Outdated Show resolved Hide resolved
dbt/models/ccbor/schema.yml Outdated Show resolved Hide resolved
@wrridgeway wrridgeway requested a review from dfsnow July 28, 2024 18:39
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all set to me @wrridgeway!

@wrridgeway wrridgeway merged commit a3d41e7 into master Jul 29, 2024
8 checks passed
@wrridgeway wrridgeway deleted the 548-ingest-bor-appeal-data-into-lake branch July 29, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest BOR appeal data into lake
2 participants