Lint etl subdirectories #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfsnow
reviewed
Dec 10, 2024
|
Yeah, everything seems to LF now. |
jeancochrane
approved these changes
Dec 11, 2024
Comment on lines
+636
to
+642
| # nolint start | ||
| # pdf(str_c("output/krig_demo/", year_num, ".pdf"), width = 11, height = 8.5) | ||
|
|
||
| #plot_surface(k) | ||
|
|
||
| #dev.off() | ||
| # plot_surface(k) | ||
|
|
||
| # dev.off() | ||
| # # nolint end |
There was a problem hiding this comment.
[Nitpick, non-blocking] Rather than turn off linting for this block, maybe we just delete the unused code that's commented out?
Comment on lines
+749
to
+750
| # raster_location <- str_c("output/kriging_surfaces/rasters/", year, ".tif") # nolint | ||
| # raster_file <- read_stars(raster_location) # nolint |
There was a problem hiding this comment.
[Nitpick, non-blocking]
Suggested change
| # raster_location <- str_c("output/kriging_surfaces/rasters/", year, ".tif") # nolint | |
| # raster_file <- read_stars(raster_location) # nolint | |
| # raster_location <- str_c("output/kriging_surfaces/rasters/", year, ".tif") # nolint | |
| # raster_file <- read_stars(raster_location) # nolint |
Comment on lines
+694
to
+695
| # Demo from 2010: | ||
| # plot_surface(out[[1]]) # nolint |
There was a problem hiding this comment.
[Nitpick, non-blocking] Same here:
Suggested change
| # Demo from 2010: | |
| # plot_surface(out[[1]]) # nolint |
There was a problem hiding this comment.
I think you're right that this should get removed, but this entire file needs to be cleaned up for extraneous code. I only wanted to address formatting in this PR so that there wouldn't be any uncertainty as to whether the insane number of changes here might lead to any changes in outputs or how code is understood.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies
styler::style_dir()toscripts-ccao-data-raw-us-east-1andscripts-ccao-data-warehouse-us-east-1.