Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure sales view row id is string #706

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Ensure sales view row id is string #706

merged 1 commit into from
Jan 14, 2025

Conversation

wrridgeway
Copy link
Member

@wrridgeway wrridgeway commented Jan 14, 2025 •
edited
Loading

Quick fix to #691 that makes sure the only row id that isn't a product of a concat operation is a string.

image

@wrridgeway wrridgeway marked this pull request as ready for review January 14, 2025 22:25
@wrridgeway wrridgeway requested a review from a team as a code owner January 14, 2025 22:25
jeancochrane
jeancochrane approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@wrridgeway wrridgeway merged commit f5dab98 into master Jan 14, 2025
7 checks passed
@wrridgeway wrridgeway deleted the open-data-sales-rowid-fix branch January 14, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeancochrane jeancochrane jeancochrane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrridgeway @jeancochrane