-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Quarto reporting #16
Add support for Quarto reporting #16
Conversation
# Upload performance report | ||
aws.s3::put_object( | ||
paths$output$report$local, | ||
paths$output$report$s3 | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here for an example report generated by this workflow run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @jeancochrane! Do you wanna also incorporate ccao-data/model-res-avm#66? Or maybe @wrridgeway can do that one?
- output/timing/model_timing.parquet: | ||
cache: false | ||
- output/metadata/model_metadata.parquet: | ||
cache: false | ||
- reports/performance.html: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really silly that your can't change the output directory of rendered Quarto docs 😬
@dfsnow If it's alright by you, I've included that in the scope of #17! I'm down to do it, and I'm also down to let Billy handle it; I just didn't want it to block this PR, since I figured that reaching parity in reporting is more urgent than reaching parity in the pipeline simplification. |
This PR mirrors the changes in ccao-data/model-res-avm#62, adding support for Quarto reporting to the model pipeline via a
reports/performance.qmd
doc that gets rendered in afinalize
step, uploaded to S3 in anupload
step, and linked in the model run SNS notification.Earlier when discussing this PR I had mentioned also mirroring the changes from ccao-data/model-res-avm#66 to extract the setup portion of each pipeline step into a separate script, but I realize now that that work depends on the dependency isolation work done in ccao-data/model-res-avm#65, so I'm going to punt that work to #17.
Closes #15.