Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize desk review workbooks #34

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Finalize desk review workbooks #34

merged 4 commits into from
Feb 15, 2024

Conversation

dfsnow
Copy link
Member

@dfsnow dfsnow commented Feb 15, 2024

This PR makes some final desk review workbook tweaks, including:

  • An additional column and conditional formatting to highlight the multi-PIN sales added in Update training data sales sample and outlier flags #30
  • Fixed neighborhood-level pivot table breakout (remove grouping by class)
  • Remove the Stories column (unnecessary for condos)
  • Replaces predicted values with NA for buildings with only parking spaces

@dfsnow dfsnow added this to the 2024 model parity and updates milestone Feb 15, 2024
@wrridgeway wrridgeway merged commit 0bed16f into master Feb 15, 2024
4 checks passed
@wrridgeway wrridgeway deleted the dfsnow/desk-review-touchups branch February 15, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrridgeway wrridgeway wrridgeway approved these changes

@jeancochrane jeancochrane Awaiting requested review from jeancochrane jeancochrane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2024 model parity and updates
Development

Successfully merging this pull request may close these issues.
2 participants
@dfsnow @wrridgeway