Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize outlier reason names #58

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

wagnerlmichael
Copy link
Member

@wagnerlmichael wagnerlmichael commented Dec 5, 2024

This PR standardizes the manually assigned outlier names from the 00-ingest.R stage. The existing method was an artifact from the older sales val specifications.

Closes #59

@wagnerlmichael wagnerlmichael self-assigned this Dec 5, 2024
@wagnerlmichael wagnerlmichael marked this pull request as ready for review December 5, 2024 22:34
Copy link
Contributor

@jeancochrane jeancochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for catching this.

@wagnerlmichael wagnerlmichael merged commit 14a6994 into master Dec 6, 2024
4 checks passed
@wagnerlmichael wagnerlmichael deleted the standardize-outlier-names branch December 6, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize outlier assignment name
3 participants