Add info from outlier reason 2 and clean up graphs #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnerlmichael
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
dfsnow
reviewed
Dec 17, 2024
reports/performance/_outliers.qmd
Outdated
Comment on lines
23
to
31
| mutate( | ||
| outlier_reasons_to_graph = if_else( | ||
| sv_is_outlier, | ||
| paste0(sv_outlier_reason1, " (", sv_outlier_reason2, ")"), | ||
| NA_character_ | ||
| ) | ||
| ) %>% | ||
| # Yank NA string values to make output cleaner | ||
| mutate(outlier_reasons_to_graph = str_remove_all(outlier_reasons_to_graph, " \\(NA\\)")) |
There was a problem hiding this comment.
suggestion (blocking): Use a case_when() here. Creating a string and then manipulating it is fragile and error-prone.
reports/performance/_outliers.qmd
Outdated
Comment on lines
268
to
269
| arrange(desc(percent)) %>% | ||
| Matrix::head(1) %>% |
There was a problem hiding this comment.
suggestion (blocking): Replace this with slice_max().
dfsnow
deleted the
add-sv-outlier-reason-2-to-outlier-performance-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more outlier information and makes a number of small improvements.