Add test for NA or NULL values #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damonamajor
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
dfsnow
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
@Damonamajor This looks set to go other than my minor nitpick.
Co-authored-by: Dan Snow <[email protected]>
Damonamajor
added a commit
that referenced
this pull request
Jan 14, 2025
* Add test * Update reports/performance/_outliers.qmd Co-authored-by: Dan Snow <[email protected]> * lintr --------- Co-authored-by: Dan Snow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in #78, NULL and NA values are often present in the Condo Pipeline. This provides counts for those values in the outliers section.