Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 fix Qiskit 0.46.0 deprecation warnings #360

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

burgholzer
Copy link
Member

Description

This PR works around some newly introduced deprecation warnings in the latest Qiskit version.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added python Anything related to Python code code quality Anything related to code quality and code style. labels Feb 5, 2024
@burgholzer burgholzer self-assigned this Feb 5, 2024
@burgholzer burgholzer enabled auto-merge (squash) February 5, 2024 16:00
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79fae0d) 96.0% compared to head (323284d) 90.5%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #360     +/-   ##
=======================================
- Coverage   96.0%   90.5%   -5.6%     
=======================================
  Files         34      34             
  Lines       1754    1754             
  Branches     215     215             
=======================================
- Hits        1685    1588     -97     
- Misses        69     166     +97     
Flag Coverage Δ *Carryforward flag
cpp 95.7% <ø> (ø) Carriedforward from 735f1e1
python 72.5% <ø> (-24.7%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

@burgholzer burgholzer merged commit 00ce22d into main Feb 5, 2024
27 checks passed
@burgholzer burgholzer deleted the qiskit-0.46-warnings branch February 5, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Anything related to code quality and code style. python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant