Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️👽 update to latest MQT Core version #531

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

burgholzer
Copy link
Member

Description

This PR updates the MQT Core version used in QCEC to the latest version. This includes changes from cda-tum/mqt-core#674 and cda-tum/mqt-core#764.
SWAP eliding is now performed explicitly in QCEC instead of implicitly in the getDD method of MQT Core.
Furthermore, states generated by the DD package now have their ref count increased by default, which required subtle changes to the ref counting scheme.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Jan 7, 2025
@burgholzer burgholzer added dependencies Pull requests that update a dependency file c++ Anything related to C++ code labels Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.7%. Comparing base (0ed735c) to head (4c57cfd).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
include/checker/dd/TaskManager.hpp 91.6% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #531     +/-   ##
=======================================
+ Coverage   95.5%   95.7%   +0.1%     
=======================================
  Files         40      40             
  Lines       1832    1840      +8     
  Branches     224     225      +1     
=======================================
+ Hits        1751    1762     +11     
+ Misses        81      78      -3     
Flag Coverage Δ
cpp 96.3% <94.1%> (+0.2%) ⬆️
python 93.7% <ø> (ø)
Files with missing lines Coverage Δ
src/checker/dd/DDAlternatingChecker.cpp 98.6% <100.0%> (ø)
src/checker/dd/DDSimulationChecker.cpp 100.0% <100.0%> (ø)
src/checker/dd/simulation/StateGenerator.cpp 94.9% <100.0%> (+<0.1%) ⬆️
include/checker/dd/TaskManager.hpp 97.2% <91.6%> (-1.3%) ⬇️

... and 2 files with indirect coverage changes

@burgholzer burgholzer merged commit c3fbfc2 into main Jan 8, 2025
66 checks passed
@burgholzer burgholzer deleted the update-mqt-core branch January 8, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant