Merge pull request #117 from cego/rab/skip-locked-configurable

Added config to opt out of using skip locked for older versions of mysql
cego · Dec 30, 2024 · f894364 · f894364
2 parents 9a9d05d + 3b14de3
commit f894364
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/publishable/config/request-insurance.php b/publishable/config/request-insurance.php
@@ -98,5 +98,11 @@
     'table_edits'          => null,
     'table_edit_approvals' => null,
 
-    'useDbReconnect' => env('REQUEST_INSURANCE_WORKER_USE_DB_RECONNECT', true)
+    'useDbReconnect' => env('REQUEST_INSURANCE_WORKER_USE_DB_RECONNECT', true),
+
+    /*
+     | Using skip locked optimizes request insurance to run with multiple worker threads,
+     | but is unavailable in mysql versions older than 8.0.0
+     */
+    'useSkipLocked' => env('REQUEST_INSURANCE_WORKER_USE_SKIP_LOCKED', true),
 ];
diff --git a/src/RequestInsurance/RequestInsuranceWorker.php b/src/RequestInsurance/RequestInsuranceWorker.php
@@ -310,11 +310,17 @@ public function acquireLockOnRowsToProcess(): Collection
      */
     public function getIdsOfReadyRequests()
     {
-        return resolve(RequestInsurance::class)::query()
+        $builder = resolve(RequestInsurance::class)::query()
             ->select('id')
             ->readyToBeProcessed()
-            ->take(Config::get('request-insurance.batchSize'))
-            ->lock('FOR UPDATE SKIP LOCKED')
-            ->pluck('id');
+            ->take(Config::get('request-insurance.batchSize'));
+
+        if (config('request-insurance.useSkipLockede')) {
+            $builder->lock('FOR UPDATE SKIP LOCKED');
+        } else {
+            $builder->lockForUpdate();
+        }
+
+        return $builder->pluck('id');
     }
 }