Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redo-typo-pr): added a new reusable action #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sysrex
Copy link

@sysrex sysrex commented Jan 15, 2025

Overview

@sysrex sysrex requested a review from tty47 January 15, 2025 14:18
@sysrex sysrex requested review from MSevey and a team as code owners January 15, 2025 14:18
Comment on lines +36 to +37
git config --global user.name celestia-bot
git config --global user.email [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocker -
I'd add these two values to the secrets, to don't publish them

# Step 3: Commit squash commit to new branch
echo "Creating new local branch $NEW_BRANCH"
git checkout -b $NEW_BRANCH
git commit -a --author="celestia-bot <[email protected]>" -m "chore: redo typo PR"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, maybe env var if not

Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments, otherwise LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants