Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip TestLegacyUpgrade in race mode #3111

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Feb 14, 2024

Closes #3095

@rootulp rootulp self-assigned this Feb 14, 2024
@rootulp rootulp enabled auto-merge (squash) February 14, 2024 15:49
Copy link
Contributor

coderabbitai bot commented Feb 14, 2024

Walkthrough

Walkthrough

This change primarily addresses a race condition detected in TestLegacyUpgrade by temporarily excluding it from the test-race target. Additionally, it updates a comment related to the Docker publishing process. While offering an immediate fix to prevent test failures, it points towards a more comprehensive solution discussed in another issue for long-term resolution.

Changes

File Change Summary
Makefile Updated comment for publish-ghcr-docker target.
Modified test-race target to skip TestLegacyUpgrade.

Assessment against linked issues

Objective Addressed Explanation
Identify and address the race condition in TestLegacyUpgrade (#3095) The change skips the test instead of addressing the race condition directly.
Skip TestLegacyUpgrade when running tests in upgrade mode (#3095)
Refer to a long-term solution in issue #1369 The summary mentions a long-term solution but does not include any code changes towards it.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@celestia-bot celestia-bot requested a review from a team February 14, 2024 15:50
@rootulp rootulp merged commit 1bffee2 into celestiaorg:main Feb 14, 2024
34 checks passed
@rootulp rootulp deleted the rp/skip-test-legacy-upgrade branch February 14, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestLegacyUpgrade race detected
3 participants