Merge pull request #1021 from celestiaorg/evan/bump-upstream-v0.34.28

chore!: bump upstream v0.34.28

.changelog/config.toml

@@ -0,0 +1 @@
+project_url = 'https://github.com/cometbft/cometbft' 

.changelog/epilogue.md

@@ -0,0 +1,14 @@
+---
+
+CometBFT is a fork of [Tendermint
+Core](https://github.com/tendermint/tendermint) as of late December 2022.
+
+## Bug bounty
+
+Friendly reminder, we have a [bug bounty program](https://hackerone.com/cosmos).
+
+## Previous changes
+
+For changes released before the creation of CometBFT, please refer to the
+Tendermint Core
+[CHANGELOG.md](https://github.com/tendermint/tendermint/blob/a9feb1c023e172b542c972605311af83b777855b/CHANGELOG.md).

.changelog/v0.34.27/breaking-changes/152-rename-binary-docker.md

@@ -0,0 +1,2 @@
+- Rename binary to `cometbft` and Docker image to `cometbft/cometbft`
+  ([\#152](https://github.com/cometbft/cometbft/pull/152))

.changelog/v0.34.27/breaking-changes/211-deprecate-tmhome.md

@@ -0,0 +1,3 @@
+- The `TMHOME` environment variable was renamed to `CMTHOME`, and all
+  environment variables starting with `TM_` are instead prefixed with `CMT_`
+  ([\#211](https://github.com/cometbft/cometbft/issues/211))

.changelog/v0.34.27/breaking-changes/360-update-to-go-119.md

@@ -0,0 +1,2 @@
+- Use Go 1.19 to build CometBFT, since Go 1.18 has reached end-of-life.
+  ([\#360](https://github.com/cometbft/cometbft/issues/360))

.changelog/v0.34.27/bug-fixes/383-txindexer-fix-slash-parsing.md

@@ -0,0 +1,3 @@
+- `[state/kvindexer]` Resolved crashes when event values contained slashes,
+  introduced after adding event sequences.
+  (\#[383](https://github.com/cometbft/cometbft/pull/383): @jmalicevic)

.changelog/v0.34.27/bug-fixes/386-quick-fix-needproofblock.md

@@ -0,0 +1,6 @@
+- `[consensus]` Short-term fix for the case when `needProofBlock` cannot find
+  previous block meta by defaulting to the creation of a new proof block.
+  ([\#386](https://github.com/cometbft/cometbft/pull/386): @adizere)
+  - Special thanks to the [Vega.xyz](https://vega.xyz/) team, and in particular
+    to Zohar (@ze97286), for reporting the problem and working with us to get to
+    a fix.

.changelog/v0.34.27/bug-fixes/4-busy-loop-send-block-part.md

@@ -0,0 +1,3 @@
+- `[consensus]` Fixed a busy loop that happened when sending of a block part
+  failed by sleeping in case of error.
+  ([\#4](https://github.com/informalsystems/tendermint/pull/4))

.changelog/v0.34.27/bug-fixes/9936-p2p-fix-envelope-sending.md

@@ -0,0 +1,5 @@
+- `[p2p]` Correctly use non-blocking `TrySendEnvelope` method when attempting to
+  send messages, as opposed to the blocking `SendEnvelope` method. It is unclear
+  whether this has a meaningful impact on P2P performance, but this patch does
+  correct the underlying behaviour to what it should be
+  ([tendermint/tendermint\#9936](https://github.com/tendermint/tendermint/pull/9936))

.changelog/v0.34.27/dependencies/160-tmdb-to-cometbftdb.md

@@ -0,0 +1,3 @@
+- Replace [tm-db](https://github.com/tendermint/tm-db) with
+  [cometbft-db](https://github.com/cometbft/cometbft-db)
+  ([\#160](https://github.com/cometbft/cometbft/pull/160))

.changelog/v0.34.27/dependencies/165-bump-tmloadtest.md

@@ -0,0 +1,2 @@
+- Bump tm-load-test to v1.3.0 to remove implicit dependency on Tendermint Core
+  ([\#165](https://github.com/cometbft/cometbft/pull/165))

.changelog/v0.34.27/dependencies/9787-btcec-dep-update.md

@@ -0,0 +1,3 @@
+- `[crypto]` Update to use btcec v2 and the latest btcutil
+  ([tendermint/tendermint\#9787](https://github.com/tendermint/tendermint/pull/9787):
+  @wcsiu)

.changelog/v0.34.27/features/9759-kvindexer-match-event.md

@@ -0,0 +1,3 @@
+- `[rpc]` Add `match_event` query parameter to indicate to the RPC that it
+  should match events _within_ attributes, not only within a height
+  ([tendermint/tendermint\#9759](https://github.com/tendermint/tendermint/pull/9759))

.changelog/v0.34.27/improvements/136-remove-tm-signer-harness.md

@@ -0,0 +1,2 @@
+- `[tools/tm-signer-harness]` Remove the folder as it is unused
+  ([\#136](https://github.com/cometbft/cometbft/issues/136))

.changelog/v0.34.27/improvements/204-version-commit-hash.md

@@ -0,0 +1,2 @@
+- Append the commit hash to the version of CometBFT being built
+  ([\#204](https://github.com/cometbft/cometbft/pull/204))

.changelog/v0.34.27/improvements/314-prio-mempool-badtxlog.md

@@ -0,0 +1,3 @@
+- `[mempool/v1]` Suppress "rejected bad transaction" in priority mempool logs by
+  reducing log level from info to debug
+  ([\#314](https://github.com/cometbft/cometbft/pull/314): @JayT106)

.changelog/v0.34.27/improvements/56-rpc-cache-rpc-responses.md

@@ -0,0 +1,2 @@
+- `[e2e]` Add functionality for uncoordinated (minor) upgrades
+  ([\#56](https://github.com/tendermint/tendermint/pull/56))

.changelog/v0.34.27/improvements/9733-consensus-metrics.md

@@ -0,0 +1,4 @@
+- `[consensus]` Add `consensus_block_gossip_parts_received` and
+  `consensus_step_duration_seconds` metrics in order to aid in investigating the
+  impact of database compaction on consensus performance
+  ([tendermint/tendermint\#9733](https://github.com/tendermint/tendermint/pull/9733))

.changelog/v0.34.27/improvements/9759-kvindexer-match-event.md

@@ -0,0 +1,3 @@
+- `[state/kvindexer]` Add `match.event` keyword to support condition evaluation
+  based on the event the attributes belong to
+  ([tendermint/tendermint\#9759](https://github.com/tendermint/tendermint/pull/9759))

.changelog/v0.34.27/improvements/9764-p2p-fix-logspam.md

@@ -0,0 +1,4 @@
+- `[p2p]` Reduce log spam through reducing log level of "Dialing peer" and
+  "Added peer" messages from info to debug
+  ([tendermint/tendermint\#9764](https://github.com/tendermint/tendermint/pull/9764):
+  @faddat)

.changelog/v0.34.27/improvements/9776-consensus-vote-bandwidth.md

@@ -0,0 +1,3 @@
+- `[consensus]` Reduce bandwidth consumption of consensus votes by roughly 50%
+  through fixing a small logic bug
+  ([tendermint/tendermint\#9776](https://github.com/tendermint/tendermint/pull/9776))

.changelog/v0.34.27/summary.md

@@ -0,0 +1,17 @@
+*Feb 27, 2023*
+
+This is the first official release of CometBFT - a fork of [Tendermint
+Core](https://github.com/tendermint/tendermint). This particular release is
+intended to be compatible with the Tendermint Core v0.34 release series.
+
+For details as to how to upgrade to CometBFT from Tendermint Core, please see
+our [upgrading guidelines](./UPGRADING.md).
+
+If you have any questions, comments, concerns or feedback on this release, we
+would love to hear from you! Please contact us via [GitHub
+Discussions](https://github.com/cometbft/cometbft/discussions),
+[Discord](https://discord.gg/cosmosnetwork) (in the `#cometbft` channel) or
+[Telegram](https://t.me/CometBFT).
+
+Special thanks to @wcsiu, @ze97286, @faddat and @JayT106 for their contributions
+to this release!

.changelog/v0.34.28/breaking-changes/558-tm10011.md

@@ -0,0 +1,2 @@
+- `[crypto/merkle]` Do not allow verification of Merkle Proofs against empty trees (`nil` root). `Proof.ComputeRootHash` now panics when it encounters an error, but `Proof.Verify` does not panic
+  ([\#558](https://github.com/cometbft/cometbft/issues/558))

.changelog/v0.34.28/bug-fixes/496-error-on-applyblock-should-panic.md

@@ -0,0 +1,2 @@
+- `[consensus]` Unexpected error conditions in `ApplyBlock` are non-recoverable, so ignoring the error and carrying on is a bug. We replaced a `return` that disregarded the error by a `panic`.
+  ([\#496](https://github.com/cometbft/cometbft/pull/496))

.changelog/v0.34.28/bug-fixes/524-rename-peerstate-tojson.md

@@ -0,0 +1,2 @@
+- `[consensus]` Rename `(*PeerState).ToJSON` to `MarshalJSON` to fix a logging data race
+  ([\#524](https://github.com/cometbft/cometbft/pull/524))

.changelog/v0.34.28/bug-fixes/575-fix-light-client-panic.md

@@ -0,0 +1,6 @@
+- `[light]` Fixed an edge case where a light client would panic when attempting
+  to query a node that (1) has started from a non-zero height and (2) does
+  not yet have any data. The light client will now, correctly, not panic
+  _and_ keep the node in its list of providers in the same way it would if
+  it queried a node starting from height zero that does not yet have data
+  ([\#575](https://github.com/cometbft/cometbft/issues/575))

.changelog/v0.34.28/improvements/475-upgrade-go-schnorrkel.md

@@ -0,0 +1 @@
+- `[crypto/sr25519]` Upgrade to [email protected] ([\#475](https://github.com/cometbft/cometbft/issues/475))

.changelog/v0.34.28/improvements/638-json-rpc-error-message.md

@@ -0,0 +1,3 @@
+- `[jsonrpc/client]` Improve the error message for client errors stemming from
+  bad HTTP responses.
+  ([cometbft/cometbft\#638](https://github.com/cometbft/cometbft/pull/638))

.changelog/v0.34.28/summary.md

@@ -0,0 +1,6 @@
+*April 26, 2023*
+
+This release fixes several bugs, and has had to introduce one small Go
+API-breaking change in the `crypto/merkle` package in order to address what
+could be a security issue for some users who directly and explicitly make use of
+that code.

.github/issue_template.md

@@ -0,0 +1,10 @@
+---
+labels: needs-triage
+---
+
+<!--
+
+If you want to ask a general question, please create a new discussion instead of
+an issue: https://github.com/cometbft/cometbft/discussions
+
+-->

.github/workflows/check-generated.yml

@@ -41,7 +41,7 @@ jobs:
   check-proto:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
           go-version: '1.19'
 

.github/workflows/docker.yml → .github/workflows/cometbft-docker.yml

@@ -5,8 +5,10 @@ on:
     branches:
       - v[0-9]+.[0-9]+.x-celestia
     tags:
-      - "v[0-9]+.[0-9]+.[0-9]+" # Push events to matching v*, i.e. v1.0, v20.15.10
-      - "v[0-9]+.[0-9]+.[0-9]+-rc*" # Push events to matching v*, i.e. v1.0-rc1, v20.15.10-rc5
+      - "v[0-9]+.[0-9]+.[0-9]+"               # Push events to matching v*, i.e. v1.0, v20.15.10
+      - "v[0-9]+.[0-9]+.[0-9]+-alpha.[0-9]+"  # e.g. v0.37.0-alpha.1, v0.38.0-alpha.10
+      - "v[0-9]+.[0-9]+.[0-9]+-beta.[0-9]+"   # e.g. v0.37.0-beta.1, v0.38.0-beta.10
+      - "v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+"      # e.g. v0.37.0-rc1, v0.38.0-rc10
 
 jobs:
   build:
@@ -16,7 +18,7 @@ jobs:
       - name: Prepare
         id: prep
         run: |
-          DOCKER_IMAGE=tendermint/tendermint
+          DOCKER_IMAGE=cometbft/cometbft
           VERSION=noop
           if [[ $GITHUB_REF == refs/tags/* ]]; then
             VERSION=${GITHUB_REF#refs/tags/}
@@ -30,20 +32,20 @@ jobs:
           if [[ $VERSION =~ ^v[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then
             TAGS="$TAGS,${DOCKER_IMAGE}:${VERSION}"
           fi
-          echo ::set-output name=tags::${TAGS}
+          echo "tags=${TAGS}" >> $GITHUB_OUTPUT
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@master
         with:
           platforms: all
 
-      - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v2
+      - name: Set up Docker Build
+        uses: docker/setup-buildx-action@v2.5.0
 
       - name: Build but do not Publish to Docker Hub
         uses: docker/build-push-action@v3
         with:
           context: .
           file: ./DOCKER/Dockerfile
           platforms: linux/amd64,linux/arm64
-          tags: ${{ steps.prep.outputs.tags }}
+          tags: ${{ steps.prep.outputs.tags }}

.github/workflows/coverage.yml

@@ -43,7 +43,7 @@ jobs:
     env:
       GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
           go-version: "1.19"
       - uses: actions/checkout@v3
@@ -65,7 +65,7 @@ jobs:
       matrix:
         part: ["00", "01", "02", "03"]
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
           go-version: "1.19"
       - uses: actions/checkout@v3

.github/workflows/e2e-manual.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 60
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
           go-version: '1.19'
 
@@ -28,7 +28,7 @@ jobs:
       - name: Generate testnets
         working-directory: test/e2e
         # When changing -g, also change the matrix groups above
-        run: ./generator-multiversion.sh -g 4 -d networks/nightly/
+        run: ./build/generator -g 4 -d networks/nightly -p
 
       - name: Run ${{ matrix.p2p }} p2p testnets
         working-directory: test/e2e

.github/workflows/e2e-nightly-34x.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 60
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
           go-version: '1.19'
 
@@ -37,7 +37,7 @@ jobs:
       - name: Generate testnets
         working-directory: test/e2e
         # When changing -g, also change the matrix groups above
-        run: ./build/generator -g 4 -d networks/nightly
+        run: ./build/generator -g 4 -d networks/nightly -p
 
       - name: Run testnets in group ${{ matrix.group }}
         working-directory: test/e2e

.github/workflows/e2e.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 15
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
           go-version: '1.19'
       - uses: actions/checkout@v3

.github/workflows/fuzz-nightly.yml

@@ -9,7 +9,7 @@ jobs:
   fuzz-nightly-test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
           go-version: '1.19'
 

.github/workflows/govulncheck.yml

@@ -10,21 +10,23 @@ on:
     branches:
       - v[0-9]+.[0-9]+.x-celestia
 
-jobs:
-  govulncheck:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/setup-go@v3
-        with:
-          go-version: "1.19"
-      - uses: actions/checkout@v3
-      - uses: technote-space/get-diff-action@v6
-        with:
-          PATTERNS: |
-            **/*.go
-            go.mod
-            go.sum
-            Makefile
-      - name: govulncheck
-        run: make vulncheck
-        if: "env.GIT_DIFF != ''"
+# TODO: re-enable after figuring out what needs to get fixed or if this is
+# handled upstream in main
+# jobs:
+#   govulncheck:
+#     runs-on: ubuntu-latest
+#     steps:
+#       - uses: actions/setup-go@v3
+#         with:
+#           go-version: "1.19"
+#       - uses: actions/checkout@v3
+#       - uses: technote-space/get-diff-action@v6
+#         with:
+#           PATTERNS: |
+#             **/*.go
+#             go.mod
+#             go.sum
+#             Makefile
+#       - name: govulncheck
+#         run: make vulncheck
+#         if: "env.GIT_DIFF != ''"

.github/workflows/lint.yml

@@ -19,7 +19,8 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 8
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
         with:
           go-version: '1.19'
       - uses: technote-space/get-diff-action@v6

.github/workflows/markdown-linter.yml

@@ -0,0 +1,33 @@
+name: Markdown Linter
+on:
+  push:
+    branches:
+      - v0.34.x
+    paths:
+      - "**.md"
+      - "**.yml"
+      - "**.yaml"
+  pull_request:
+    branches: [v0.34.x]
+    paths:
+      - "**.md"
+      - "**.yml"
+
+jobs:
+  build:
+    name: Super linter
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v3
+      - name: Lint Code Base
+        uses: docker://github/super-linter:v4
+        env:
+          VALIDATE_ALL_CODEBASE: true
+          DEFAULT_BRANCH: v0.34.x
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          VALIDATE_MD: true
+          VALIDATE_OPENAPI: true
+          VALIDATE_YAML: true
+          YAML_CONFIG_FILE: yaml-lint.yml
+          FILTER_REGEX_EXCLUDE: "/workspace/tools/mintnet-kubernetes/*.yaml | /workspace/tools/mintnet-kubernetes/examples/*.yaml | workspace/tools/mintnet-kubernetes/assets/*.yaml | /workspace/tools/mintnet-kubernetes/examples/dummy/*.yaml | /workspace/tools/mintnet-kubernetes/examples/counter/*.yaml"