refactor(share/availability): Move window and constants to share/availability pkg

[renaynay]

Partially addresses #3394

• moves the concept of availability window to the share/availability package where it belongs and changes the names to be more clear -- light.Window -> availability.RequestWindow ; full.Window -> availability.StorageWindow
• limits the use of availability.Window to the nodebuilder only, use time.Duration everywhere else
• removes archival window in favour of using explicit time.Duration(0) -- will be removed entirely in follow-up PRs.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 68.08511% with 15 lines in your changes missing coverage. Please review.

Project coverage is 45.27%. Comparing base (2469e7a) to head (d29b45c).
Report is 383 commits behind head on main.

Files with missing lines	Patch %	Lines
nodebuilder/pruner/module.go	68.42%	6 Missing ⚠️
share/availability/window.go	0.00%	5 Missing ⚠️
das/daser.go	0.00%	0 Missing and 1 partial ⚠️
nodebuilder/das/constructors.go	0.00%	1 Missing ⚠️
nodebuilder/pruner/constructors.go	0.00%	1 Missing ⚠️
share/shwap/p2p/bitswap/getter.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3906      +/-   ##
==========================================
+ Coverage   44.83%   45.27%   +0.43%     
==========================================
  Files         265      308      +43     
  Lines       14620    21853    +7233     
==========================================
+ Hits         6555     9894    +3339     
- Misses       7313    10884    +3571     
- Partials      752     1075     +323     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[walldiss]

Handling pruning windows just got a whole lot easier! It would be awesome to rename the variables so it's clear which window they're using. Right now, names like "window," "samplingWindow," and "availWindow" can be confusing inside the component. Being more specific about which of the two new windows is being used would help a lot.

Don’t forget the functions too, like changing WithAvailabilityWindow to WithStorageWindow. These tweaks would make the code easier to understand for everyone.

[renaynay]

@walldiss

Right now, names like "window," "samplingWindow," and "availWindow" can be confusing inside the component

I plan to move those parameters outside of those components entirely (with exception of core pkg n which case I will name it to StorageWindow)

[cristaloleg]

Should #3912 be closed?

[renaynay]

no #3912 is based on this PR @cristaloleg