Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction decoding may result in a stack overflow or resource exhaustion #422

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

cmwaters
Copy link

  • Limit recursion depth for unknown field detection

  • Limit unpack any

(cherry picked from commit 1a2bff56fb7391f9ce87d4fbe9e0367ae991c0b2)

* Limit recursion depth for unknown field detection

* Limit unpack any

(cherry picked from commit 1a2bff56fb7391f9ce87d4fbe9e0367ae991c0b2)

* Update changelog
@cmwaters cmwaters requested a review from a team as a code owner December 16, 2024 16:40
@cmwaters cmwaters requested review from rootulp and rach-id and removed request for a team December 16, 2024 16:40
Copy link
Member

@ninabarbakadze ninabarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint needs fixing and potentially tests

@rootulp rootulp changed the title Cherry pick commit from upstream v0.47.15 fix: transaction decoding may result in a stack overflow or resource exhaustion Dec 16, 2024
@rootulp
Copy link
Collaborator

rootulp commented Dec 16, 2024

Renamed PR title to appease the Lint PR CI

@cmwaters cmwaters merged commit e40d16e into release/v0.46.x-celestia Dec 16, 2024
32 of 34 checks passed
@cmwaters cmwaters deleted the cal/unpack-overflow branch December 16, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants