Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some problematic function names and typos in comment #2337

Closed
wants to merge 2 commits into from

Conversation

hishope
Copy link

@hishope hishope commented Nov 30, 2024

Description

fix some problematic function names and typos in comment

Other changes

Tested

No need.

Related issues

  • Fixes #[issue number here]

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

@palango
Copy link
Contributor

palango commented Jan 20, 2025

Thanks for your PR. As we're currently focusing on developing the L2 we won't merge PRs that fix typos, but feel free to open them to upstream go-ethereum.

@palango palango closed this Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.94%. Comparing base (f0adb14) to head (a8707dd).
Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
miner/block.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2337      +/-   ##
==========================================
- Coverage   55.06%   54.94%   -0.12%     
==========================================
  Files         684      685       +1     
  Lines      114596   114962     +366     
==========================================
+ Hits        63097    63162      +65     
- Misses      47617    47895     +278     
- Partials     3882     3905      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants