Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContractCall mode #10778

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Add ContractCall mode #10778

merged 3 commits into from
Nov 23, 2023

Conversation

carterqw2
Copy link
Contributor

@carterqw2 carterqw2 commented Nov 22, 2023

Description

Based on @eelanagaraj's PR

New mode that simulates contract calls.

Other changes

Additionally:

  • cleans up some obsolete code
  • provides additional informational context for the --client-count parameter
  • refactors the simulateClient method and extracts some shared parameters of the load test from the main loop

Tested

Tested on a local devnet.

Related issues

Backwards compatibility

Yes.

Based on @eelanagaraj PR
https://github.com/celo-org/celo-monorepo/pull/10354/files

New mode that simulates contract calls.
Additionally:
- cleans up some obsolete code
- provides additional informational context for the --client-count parameter
- refactors the simulateClient method and extracts some shared parameters of
  the load test from the main loop
@carterqw2 carterqw2 requested a review from a team as a code owner November 22, 2023 15:44
@carterqw2 carterqw2 requested a review from alvarof2 November 22, 2023 15:44
Copy link

changeset-bot bot commented Nov 22, 2023

⚠️ No Changeset found

Latest commit: e1a00f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit detail, but LGTM

packages/celotool/src/lib/geth.ts Outdated Show resolved Hide resolved
@carterqw2 carterqw2 enabled auto-merge (squash) November 22, 2023 21:33
@carterqw2 carterqw2 merged commit 06768e2 into master Nov 23, 2023
36 checks passed
@carterqw2 carterqw2 deleted the carterqw2/load-testing-contract-call branch November 23, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants