Fix PrecompileOverride bug
#11269
Open
Fix PrecompileOverride bug
#11269
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvol
reviewed
Nov 19, 2024
Comment on lines
266
to
271
| contract TransitionToL2After is GovernanceTest { | ||
| function setUp() public { | ||
| super.setUp(); | ||
| _whenL2(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can this be defined in a general purpose util?
soloseng
changed the title
PrecompileOverride bug
|
Can we write a forge test for this? |
m-chrzan
reviewed
Feb 3, 2025
| @@ -442,7 +442,7 @@ describe('governance tests', () => { | |||
|
|
|||
| // groupKit uses a different node than kit does, so wait a second in case kit's node | |||
| // got the new block before groupKit's node did. | |||
| await sleep(1) | |||
| await sleep(5) | |||
There was a problem hiding this comment.
Why was this increase necessary? Out of scope for this PR, but do we have any way to do an exact wait, rather than an arbitrary sleep?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Governance e2e test was failing on CI.
After investigating, I found that when calling the
validatorSignerAddressFromCurrentSet()function in thePrecompileOverridecontract on L1, the function did not return the value. Since the unit test dont actually test the precompiles, this error remained unnoticed until now.Tested
All e2e test and unit test are now passing.