Enh servicedisco api migrate

[kduret]

Description

Migrated from centreon/centreon#3880

Removes the use of CLAPI in the service discovery part of the autodiscovery module that can be painful to use with complicated passwords. It's also the aim of all Gorgone's modules.
Also maps settings in configuration file to be able to change the frequency of the discoveries.

Type of change

• Patch fixing an issue (non-breaking change)
• New functionality (non-breaking change)
• Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

• 22.04.x
• 22.10.x
• 23.04.x
• 23.10.x
• 24.04.x (master)

How this pull request can be tested ?

1. Have some discovery rules configured and enabled,
2. Make sure to have something to be discovered and added to configuration,
3. Look at the logs for configuration generation:

2024-04-16 13:48:50 - INFO - [autodiscovery] -servicediscovery- 005cfc72:41 generate poller config '8'
2024-04-16 13:48:50 - DEBUG - == Info: Found bundle for host mycentral.domain.com: 0x558400333ec0 [can pipeline]
2024-04-16 13:48:50 - DEBUG - == Info: Re-using existing connection! (#746) with host mycentral.domain.com
2024-04-16 13:48:50 - DEBUG - == Info: Connected to mycentral.domain.com (10.2.3.4) port 443 (#746)
2024-04-16 13:48:50 - DEBUG - == Info: TLSv1.3 (OUT), TLS app data, [no content] (0):
2024-04-16 13:48:50 - DEBUG - => Send header: GET /centreon/api/latest/configuration/monitoring-servers/8/generate-and-reload?limit=10000&page=1 HTTP/1.1
Host: mycentral.domain.com
Accept: */*
Accept-Type: application/json; charset=utf-8
Content-Type: application/json; charset=utf-8
X-AUTH-TOKEN: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
2024-04-16 13:48:54 - DEBUG - == Info: TLSv1.3 (IN), TLS app data, [no content] (0):
2024-04-16 13:48:54 - DEBUG - => Recv header: HTTP/1.1 204 No Content
2024-04-16 13:48:54 - DEBUG - => Recv header: Date: Tue, 16 Apr 2024 11:48:53 GMT
2024-04-16 13:48:54 - DEBUG - => Recv header: Server: Apache
2024-04-16 13:48:54 - DEBUG - => Recv header: Cache-Control: no-cache, private
2024-04-16 13:48:54 - DEBUG - => Recv header: Api-Version: 23.04
2024-04-16 13:48:54 - DEBUG - => Recv header: X-Robots-Tag: noindex
2024-04-16 13:48:54 - DEBUG - => Recv header: Strict-Transport-Security: max-age=31536000; includeSubDomains
2024-04-16 13:48:54 - DEBUG - => Recv header: X-Frame-Options: sameorigin
2024-04-16 13:48:54 - DEBUG - => Recv header:
2024-04-16 13:48:54 - DEBUG - == Info: Connection #746 to host mycentral.domain.com left intact

Checklist

Community contributors & Centreon team

• I have followed the coding style guidelines provided by Centreon
• I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
• I have commented my code, especially hard-to-understand areas of the PR.
• I have rebased my development branch on the base branch (master, maintenance).

Summary by CodeRabbit

• New Features

  • Enhanced the Autodiscovery module with new configuration directives for service discovery.
  • Introduced a method to trigger a reload for a monitoring server.

• Bug Fixes

  • Resolved a formatting issue in the get_platform_versions method.
  • Adjusted timeouts in service command executions to align with new configurations.

• Documentation

  • Updated documentation for the Autodiscovery module with new configuration directives and default values.

• Refactor

  • Updated the usage of internal APIs and methods across several modules for improved robustness and efficiency.
  • Renamed and refactored code for clearer understanding and maintenance.

[coderabbitai]

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

• coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.