rgw/admin: parse more fields by bucket struct

[clwluvw]

The bucket's versioning information and ObjectLock status are now accessible by the Bucket struct.

Checklist

• Added tests for features and functional changes
• Public functions and types are documented
• Standard formatting is applied to Go code
• Is this a new API? Added a new file that begins with //go:build ceph_preview
• Ran make api-update to record new APIs

[clwluvw]

@anoopcs9 @phlogistonjohn Can you please take a look?

[phlogistonjohn]

Seems OK on first glance, but I'm not too knowledgeable about RGW. What would fill me with confidence would be a unit test or two :-)

[phlogistonjohn]

Thanks for adding a test! The general strucutre looks good but there's something about it failing on the older versions FWIW.

[clwluvw]

I tried to skip the tests for versions doesn't support reporting versioning and object lock with suite.T().Skip() but apparently go doesn't like them:

=== NAME  TestRadosGWTestSuite/TestBucket
    bucket_test.go:64: versioning is not reported in bucket stats
=== NAME  TestRadosGWTestSuite/TestBucket/enable_versioning
    testing.go:1577: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test

--- FAIL: TestRadosGWTestSuite/TestBucket/enable_versioning (0.00s)

Not sure what is the best way to skip them. @phlogistonjohn Do you have any idea?

[phlogistonjohn]

Would something along these lines work for your use case?

go-ceph/rbd/admin/msschedule_complex_test.go

Line 17 in 1db0abc

func skipIfQuincy(t *testing.T) {

[clwluvw]

@phlogistonjohn I was skipping the whole suite. Now it should be fixed. Can you take another look?

[phlogistonjohn]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[phlogistonjohn]

Generally, lgtm but I want a 2nd pair of eyes on this because rgw is my weakest area in the codebase.

[anoopcs9]

Can we have the subject for commit messages updated to include a / to read rgw/admin: xx?

Also are we in agreement to close #1058 once the current set of changes gets merged?

Pull request has been modified.

[clwluvw]

@anoopcs9 Can you please take another look?

[anoopcs9]

lgtm, thanks.