Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this removes the single point model and instead make both the aggregation and allocation models use a shared interface.
The library now exports 3 reader classes:
GenericReader
to query documentsSetReader
which extendsGenericReader
with the ability to load deterministic (set
account relation) documentsPointsReader
which wraps bothGenericReader
to query allocation documents andSetReader
to load aggregation documents. Other than needing to usePointsReader.create()
instead ofnew PointsReader()
, the public APIs haven't changed.It also exports 3 writer classes:
ListWriter
which extendsGenericReader
with the ability to create non-deterministic (list
account relation) documentsSetWriter
which extendsSetReader
with the ability to update deterministic (set
account relation) documentsPointsWriter
which wraps bothListWriter
to interact with the allocation documents andSetWriter
to interact with the aggregation documents. Other than needing to usePointsWriter.fromAuthenticated()
instead ofnew PointsWriter()
, the public APIs haven't changed.