Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update script to fetch test binaries #20

Closed
wants to merge 1 commit into from

Conversation

mansona
Copy link

@mansona mansona commented Feb 10, 2021

Hey folks 👋

I'm super new to Go so I'm kinda struggling to setup my webhook from this example repo 🙈 I did notice there was some chatter in #3 to make this a little simpler for beginners so I thought I would update the script that downloads the binary files.

I know there was an example script in that issue but I instead took inspiration from https://go.kubebuilder.io/quick-start.html 👍

Let me know if you want me to update anything to help get this merged

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 10, 2021
@jetstack-bot
Copy link
Contributor

@mansona: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2021
@jakexks
Copy link
Member

jakexks commented Feb 23, 2021

Hi, thanks for your contribution!
I tidied up the repo based on the outstanding PRs, so hopefully make test will now work for this use case.
/close

@jetstack-bot
Copy link
Contributor

@jakexks: Closed this PR.

In response to this:

Hi, thanks for your contribution!
I tidied up the repo based on the outstanding PRs, so hopefully make test will now work for this use case.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants