Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional tools #65

Merged
merged 5 commits into from
Oct 31, 2024
Merged

additional tools #65

merged 5 commits into from
Oct 31, 2024

Conversation

patrickuhlmann
Copy link
Contributor

add cevimail and ceviwiki

@patrickuhlmann patrickuhlmann requested a review from wp99cp October 20, 2024 14:39
Copy link

github-actions bot commented Oct 20, 2024

Visit the preview URL for this PR (updated for commit 11ee4a9):

https://cevi-tools-preview-deployment--dev-qzij2edz.web.app

(expires Thu, 07 Nov 2024 20:47:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b604e2774867f6a36756d8fb9189319fa2558852

Copy link
Member

@maede97 maede97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two remarks for the clipboard images.

assets/tools-frontpage/Source/kursfinder.png Show resolved Hide resolved
assets/tools-frontpage/Source/ceviemail.png Show resolved Hide resolved
Copy link
Member

@wp99cp wp99cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me now

@maede97
Copy link
Member

maede97 commented Oct 21, 2024

Why do we need to store the pictures now twice? once in source folder, once outside?
isn't it enough to store them where the image is actually needed and in the source folder we only store the txt file?

@patrickuhlmann
Copy link
Contributor Author

patrickuhlmann commented Oct 21, 2024

I edited the images

Why do we need to store the pictures now twice? once in source folder, once outside? isn't it enough to store them where the image is actually needed and in the source folder we only store the txt file?

I edited the images that we actually use (made them quadratic), the original images can be used for reverse image search or also if other editing (e. g. adding cevi logo etc.) should take place. Images can disappear from openclipart. The idea of the original webpage screenshot was also to have some proof that the images are actually from openclipart and see the name of the author etc.Just to have something to work in case there would be an Abmahnung or something similar. From personal experience I know that sometimes the internet can be quite short lived and links soon won't work anymore leaving people with no clue what was actually there at the time we took it.

@patrickuhlmann
Copy link
Contributor Author

two remarks for the clipboard images.

Can I merge it?

@maede97
Copy link
Member

maede97 commented Oct 30, 2024

Sorry, did not see your comment before. Merge it! :-)

@patrickuhlmann patrickuhlmann force-pushed the feature/additional_tools branch from 0ebda34 to 11ee4a9 Compare October 31, 2024 20:46
@patrickuhlmann patrickuhlmann merged commit aa8e2f7 into main Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants