ENT-11094: Improved rpm verification for hub package #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cf-bottom jenkins, please. |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10156/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10156/ |
vpodzime
reviewed
Dec 13, 2023
…nt hash As a log file it's expected to change and be rotated, so rpm verification should not target content hash or file time. Ticket: ENT-11094 Changelog: Title
Ticket: ENT-11094 Changelog: Title
runalerts.php is rendered by policy, as such its content and file time are expected to change. This modification excludes file time and md5 content from RPM verification. Ticket: ENT-11094 Changelog: Title
nickanderson
force-pushed
the
ENT-11094/master
branch
from
23e502b to
ff5b96a
Compare
|
@cf-bottom jenkins, please. |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10183/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10183/ |
craigcomstock
previously approved these changes
Dec 18, 2023
nickanderson
dismissed stale reviews from craigcomstock and vpodzime
via
0af44af
nickanderson
force-pushed
the
ENT-11094/master
branch
from
0af44af to
1c2d447
Compare
nickanderson
force-pushed
the
ENT-11094/master
branch
from
1c2d447 to
bc18449
Compare
|
@cf-bottom jenkins, please. |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10254/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10254/ |
|
Last build was green. Shall we merge to master? |
craigcomstock
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: cfengine/masterfiles#2797