Modified hub package install scriptlet to use hostname -s and fail if that is longer than 64 characters #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
… that is longer than 64 characters We create a self-signed certificate and the CN must be 64 characters or less so use hostname -s instead of hostname -f and fail if even the short name is longer than 64 characters. This check is added to the preinstall scriptlet so that the package will not even be unpacked if hostname -s is longer than 64 characters long. This check is only activated if there is no current cert present such as during an upgrade. Ticket: CFE-4469 Changelog: title libre
craigcomstock
force-pushed
the
CFE-4469/master
branch
from
12a9898 to
decaa42
Compare
|
See if I can get the package to not even install with a preinstall check for hostname -s being less than 64 characters. |
… deployment-tests workflow artifacts No need to duplicate the saving of packages. Almost always we will build the package and save it as an artifact during the build_cfengine_hub_package workflow. Ticket: none Changelog: none
craigcomstock
force-pushed
the
CFE-4469/master
branch
from
acd7659 to
a1f5d35
Compare
|
@cf-bottom jenkins |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11516/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11516/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create a self-signed certificate and the CN must be 64 characters or less so use hostname -s instead of hostname -f and fail if even the short name is longer than 64 characters.
Ticket: CFE-4469
Changelog: title