Allocate receive buffer on stack instead of heap

Changed to code in `CopyRegularFileNet` to allocate the receive buffer
on the stack instead of the heap. There is no reason to have it
dynamically allocated since the size is constant. Furthermore, the
buffer is allocated and destroyed in the same scope.

Ticket: None
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>

libcfnet/client_code.c

@@ -748,7 +748,8 @@ bool CopyRegularFileNet(const char *source, const char *dest, off_t size,
 {
     assert(conn != NULL);
 
-    char *buf, workbuf[CF_BUFSIZE], cfchangedstr[265];
+    char buf[CF_BUFSIZE + sizeof(int)]; /* Note CF_BUFSIZE not buf_size !! */
+    char workbuf[CF_BUFSIZE], cfchangedstr[265];
     const int buf_size = 2048;
 
     /* We encrypt only for CLASSIC protocol. The TLS protocol is always over
@@ -793,8 +794,6 @@ bool CopyRegularFileNet(const char *source, const char *dest, off_t size,
         return false;
     }
 
-    buf = xmalloc(CF_BUFSIZE + sizeof(int));    /* Note CF_BUFSIZE not buf_size !! */
-
     Log(LOG_LEVEL_VERBOSE, "Copying remote file '%s:%s', expecting %jd bytes",
           conn->this_server, source, (intmax_t)size);
 
@@ -838,7 +837,6 @@ bool CopyRegularFileNet(const char *source, const char *dest, off_t size,
                 conn->this_server, source, n_read);
 
             close(dd);
-            free(buf);
             return false;
         }
 
@@ -850,7 +848,6 @@ bool CopyRegularFileNet(const char *source, const char *dest, off_t size,
             Log(LOG_LEVEL_INFO, "Network access to '%s:%s' denied",
                 conn->this_server, source);
             close(dd);
-            free(buf);
             return false;
         }
 
@@ -859,7 +856,6 @@ bool CopyRegularFileNet(const char *source, const char *dest, off_t size,
             Log(LOG_LEVEL_INFO, "Source '%s:%s' changed while copying",
                 conn->this_server, source);
             close(dd);
-            free(buf);
             return false;
         }
 
@@ -877,7 +873,6 @@ bool CopyRegularFileNet(const char *source, const char *dest, off_t size,
             Log(LOG_LEVEL_INFO, "Network access to cleartext '%s:%s' denied",
                 conn->this_server, source);
             close(dd);
-            free(buf);
             return false;
         }
 
@@ -888,7 +883,6 @@ bool CopyRegularFileNet(const char *source, const char *dest, off_t size,
             Log(LOG_LEVEL_ERR,
                 "Local disk write failed copying '%s:%s' to '%s'",
                 conn->this_server, source, dest);
-            free(buf);
             unlink(dest);
             close(dd);
             FlushFileStream(conn->conn_info->sd, size - n_wrote_total - n_read);
@@ -908,7 +902,6 @@ bool CopyRegularFileNet(const char *source, const char *dest, off_t size,
             unlink(dest);
             FlushFileStream(conn->conn_info->sd, size - n_wrote_total);
             close(dd);
-            free(buf);
             return false;
         }
     }
@@ -920,11 +913,9 @@ bool CopyRegularFileNet(const char *source, const char *dest, off_t size,
     if (!ret)
     {
         unlink(dest);
-        free(buf);
         FlushFileStream(conn->conn_info->sd, size - n_wrote_total);
         return false;
     }
 
-    free(buf);
     return true;
 }