Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core examples for simple small examples to files promise type docs #5046

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Core examples for simple small examples to files promise type docs #5046

merged 1 commit into from
Mar 18, 2024

Conversation

nickanderson
Copy link
Member

@nickanderson nickanderson commented Sep 8, 2022 •
edited
Loading

Intended to replace the inline examples introduced to docs here: cfengine/documentation#2877, see comment: cfengine/documentation#2877 (review)

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please.

Feels like overkill, but the core examples used to be part of the travis tests and I don't know how to ask for a smaller build.

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/8583/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-8583/

larsewi
larsewi previously approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in commit message, otherwise LGTM.

@olehermanse olehermanse changed the title Core examples for simple small examples to files promise tyupe docs Core examples for simple small examples to files promise type docs Sep 9, 2022
@olehermanse
Copy link
Member

@cf-bottom jenkins, please

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/8593/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-8593/

@olehermanse
Copy link
Member

@cf-bottom jenkins again, please

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/8595/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-8595/

larsewi
larsewi previously approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@nickanderson nickanderson force-pushed the simple-small-examples-files-promise-type-docs/master branch 2 times, most recently from 3832ce4 to d97426a Compare September 13, 2022 20:52
@olehermanse
Copy link
Member

@cf-bottom please test this again in Jenkins

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/8627/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-8627/

@nickanderson
Copy link
Member Author

@cf-bottom please test this again in Jenkins

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/8756/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-8756/

@nickanderson nickanderson force-pushed the simple-small-examples-files-promise-type-docs/master branch from d97426a to c8f75b2 Compare May 10, 2023 14:07
@nickanderson
Copy link
Member Author

Rebased.

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please.

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/9444/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9444/

@nickanderson nickanderson force-pushed the simple-small-examples-files-promise-type-docs/master branch 2 times, most recently from fa68bf4 to 8a521db Compare February 8, 2024 21:09
@nickanderson
Copy link
Member Author

Alright, fixed up the examples to include inform true so that info level messages would be emitted and fixed up expected outputs.

@olehermanse
Copy link
Member

@cf-bottom jenkins, please

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10431/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10431/

@larsewi
Copy link
Contributor

larsewi commented Feb 26, 2024

@cf-bottom jenkins please :)

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10503/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10503/

@larsewi
Copy link
Contributor

larsewi commented Mar 5, 2024

This line

info: Created file "/tmp/not-ubuntu_16-or-ubuntu_14", mode 0600

from examples/files-create-class-expression.cf is not printed on Ubuntu 16, and that's probably why it fails on Ubuntu 16

@nickanderson
Copy link
Member Author

Alright, let's target linux instead ...

@cf-bottom jenkins please :)

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10527/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10527/

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, again please

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10528/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10528/

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, again please

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/10530/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10530/

larsewi
larsewi approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated. Please squash commits ✅

@nickanderson nickanderson force-pushed the simple-small-examples-files-promise-type-docs/master branch from fc7674b to fac5fce Compare March 18, 2024 15:54
@nickanderson nickanderson merged commit e44ff4b into cfengine:master Mar 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsewi larsewi larsewi approved these changes

@olehermanse olehermanse Awaiting requested review from olehermanse

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickanderson @cf-bottom @olehermanse @larsewi