Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-10432: Added new platform-agnostic constant linesep #5373

Merged
merged 3 commits into from
Nov 14, 2023
Merged

ENT-10432: Added new platform-agnostic constant linesep #5373

merged 3 commits into from
Nov 14, 2023

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Nov 13, 2023 •
edited
Loading

  • Added new platform-agnostic constant linesep
  • Added linesep to constants example
  • Added acceptance test for linesep constant

Merge together with cfengine/documentation#3106

  • Tested manually on Windows Server 2019

@larsewi
Copy link
Contributor Author

larsewi commented Nov 13, 2023

@cf-bottom Jenkins please :)

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/build-and-deploy-docs-master/92/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-build-and-deploy-docs-master-92/

Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-build-and-deploy-docs-master-92/output/_site/

@craigcomstock craigcomstock changed the title ENT-10432: Added new platform-agnositc constant linesep ENT-10432: Added new platform-agnostic constant linesep Nov 13, 2023
@craigcomstock
Copy link
Contributor

@larsewi s/agnositc/agnostic/ in your commit description. I fixed the title.

@larsewi
Added new platform-agnostic constant linesep
aba2cf5 
Added new platform-agnostic constant `linesep`, which evaluates to
`\r\n` on Windows, otherwise `\n`.

Ticket: ENT-10432
Changelog: Commit
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
Added linesep to constants example
55795cf 
Ticket: ENT-10432
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi
Added acceptance test for linesep constant
118d225 
Ticket: ENT-10432
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
@larsewi larsewi marked this pull request as ready for review November 14, 2023 12:22
@larsewi larsewi merged commit d508301 into cfengine:master Nov 14, 2023
12 checks passed
vpodzime
vpodzime reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about MacOS? Also, don't forget to update docs! 👍 otherwise

@larsewi
Copy link
Contributor Author

larsewi commented Nov 16, 2023 •
edited
Loading

What about MacOS?

macOS is same as Linux?

@vpodzime
Copy link
Contributor

macOS is same as Linux?

Good 😌 I recalled it doing \r only, to complete the set.

@olehermanse
Copy link
Member

Haha, that was actually the case (a long time ago). Luckily the UNIX way won :)

@larsewi
Copy link
Contributor Author

larsewi commented Nov 17, 2023

Also, don't forget to update docs!

cfengine/documentation#3106 @vpodzime

@larsewi larsewi deleted the linesep branch December 3, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime left review comments

@olehermanse olehermanse olehermanse approved these changes

@craigcomstock craigcomstock Awaiting requested review from craigcomstock

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@larsewi @cf-bottom @craigcomstock @vpodzime @olehermanse