Fedora 39 based static checks and necessary fixes #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last argument is buffer size into which the string including the terminating NUL byte has to fit.
The latter is deprecated since curl 7.85.0.
We use the observable name as a suffix for varible names so it cannot be of the full maximum variable name length. And we should also be more careful with the lengths of the observables' descriptions.
Otherwise it fails with the following:
```
logging.c:330:6: error: conflicting types for 'LogToSystemLogStructured' due to enum/integer mismatch; have 'void(const int, ...)' [-Werror=enum-int-mismatch]
330 | void LogToSystemLogStructured(const int level, ...)
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from logging.c:25:
./logging.h:147:6: note: previous declaration of 'LogToSystemLogStructured' with type 'void(LogLevel, ...)'
147 | void LogToSystemLogStructured(LogLevel level, ...);
| ^~~~~~~~~~~~~~~~~~~~~~~~
```
Freshly released, with the latest and greatest tools.
vpodzime
force-pushed
the
master-f39_static_checks
branch
from
b856fee to
032c83f
Compare
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10074/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10074/ |
larsewi
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.