Migrate to PCRE2 #5391
Merged
Migrate to PCRE2 #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
vpodzime
force-pushed
the
master-pcre2
branch
3 times, most recently
from
e43e6ce to
af87080
Compare
PCRE has been deprecated for long enough. Ticket: ENT-10629 Changelog: CFEngine now uses PCRE2 for regular expressions
vpodzime
force-pushed
the
master-pcre2
branch
from
af87080 to
6fa0f1b
Compare
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10146/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10146/ |
|
@cf-bottom jenkins with exotics, please |
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/10147/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10147/ |
|
Build with the |
Unrelated failures only. |
Makes things nicer than using the PCRE2's `pcre2_code` type directly as it provides at least a little bit of abstraction. Introduced in NorthernTechHQ/libntech@8b678ccbc7010. Ticket: ENT-10629 Changelog: None
vpodzime
force-pushed
the
master-pcre2
branch
from
b8d35d1 to
65b08fa
Compare
craigcomstock
approved these changes
Dec 12, 2023
vpodzime
added a commit
to vpodzime/oss-fuzz
that referenced
this pull request
Dec 13, 2023
Since cfengine/core#5391, fuzzing CFEngine requires PCRE2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCRE has been deprecated for long enough.
Ticket: ENT-10629
Changelog: CFEngine now uses PCRE2 for regular expressions
Merge together:
#5391
cfengine/buildscripts#1343
https://github.com/cfengine/enterprise/pull/779
https://github.com/cfengine/nova/pull/2160