CFE-4274: In configure.ac, force with-systemd-socket=no when with-systemd-service=no #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a pull request! Maybe @larsewi can review this? |
|
I checked this with no changes on master and it seems broken, so investigating and will try to fix. |
|
waiting on #5427 to prove things are alright here as well. |
…ce=no Previously --with-systemd-socket is defaulted to true always. If a system has libsystemd-dev and configure is called with --with-systemd-service=no the build would fail. Ticket: CFE-4274 Changelog: none
craigcomstock
force-pushed
the
fix_protocol_test
branch
from
e396052 to
a12d12a
Compare
craigcomstock
commented
Jan 17, 2024
larsewi
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously --with-systemd-socket is defaulted to true always.
If a system has libsystemd-dev and configure is called with --with-systemd-service=no the build would fail.
Ticket: CFE-4274
Changelog: none