CFE-4454: Fixed ODR violations in ASAN Unit Tests #5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
larsewi
commented
Dec 9, 2024
•
larsewi
commented
- Fixed ODR violations in ASAN Unit Tests
- Revert "Disabled ODR violation from ASAN Unit Tests"
larsewi
changed the title
larsewi
force-pushed
the
violation
branch
9 times, most recently
from
cdd32a8 to
3ffe1ac
Compare
Ticket: CFE-4454 Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
This reverts commit 1589aa3. Ticket: CFE-4454 Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
For some reason rlist_test fails in macOS unit tests. The test seems to `abort()` while it should trigger an assert so that `expect_assert_failure()` can catch it. For some reason this is not happening anymore. ``` rlist.c:135: Programming Error: Internal error: Rval contains type f instead of expected scalar ``` I created a ticket (CFE-4473) to follow-up on this. Ticket: None Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11518/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11518/ |
|
Debian 11 failure is unrelated |
craigcomstock
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.