CFE-4414: cf-net connect now exits with 1 in case of error
#5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
larsewi
commented
Jan 3, 2025
•
larsewi
commented
``` $ sudo /var/cfengine/bin/cf-net -H 192.168.123.456 connect Failed to connect to '192.168.123.456' $ echo $? 1 $ sudo /var/cfengine/bin/cf-net -H 127.0.0.1 connect Connected & authenticated successfully to '127.0.0.1' $ echo $? 0 ``` Ticket: CFE-4414 Changelog: Title Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
changed the title
cf-net connect now exits with 1 in case of errorcf-net connect now exits with 1 in case of error
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11572/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11572/ |
craigcomstock
requested changes
Jan 3, 2025
vpodzime
approved these changes
Jan 6, 2025
| @@ -472,7 +472,9 @@ static int CFNetRun(CFNetOptions *opts, char **args, char *hostnames) | |||
| int ret = 0; | |||
There was a problem hiding this comment.
So ret was not set to anything else than 0 before? Weird that we haven't been getting any warning/errors for this.
There was a problem hiding this comment.
I guess because we return ret in the end.
craigcomstock
approved these changes
Jan 6, 2025
olehermanse
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.