CFE-2780: Fixed warnings from automake #5678
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
larsewi
commented
Jan 9, 2025
•
larsewi
commented
This way we don't get annoying warnings like: ``` warning: source file '$(srcdir)/../../libutils/statistics.c' is in a subdirectory, but option 'subdir-objects' is disabled ``` Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
changed the title
Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
`AC_LANG_C` is expanded from `ACX_PTHREAD` which is also obsolete. It was renamed to `AX_PTHREAD`. We may have to install `autoconf-archive` as a dependency in order to get this macro. ``` configure.ac:134: warning: The macro `AC_LANG_C' is obsolete. configure.ac:134: You should run autoupdate. ./lib/autoconf/c.m4:72: AC_LANG_C is expanded from... m4/acinclude.m4:3: ACX_PTHREAD is expanded from... ``` Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
autoconf-archive is needed for `AX_PTHREAD` macro Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
We need configure.ac to be supported on older platforms Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
``` tests/acceptance/Makefile.am:103: warning: wildcard [0-9]*: non-POSIX variable name tests/acceptance/Makefile.am:103: (probably a GNU make extension) ``` Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
Looks like 520144f was an attempt to fix init_script_test_helper from not being cleaned properly. This commit was reverted in ebd97bd, and another attempt was added in 9dc759f. However, the revert actually removed the entire `init_script_test_helper` binary from being compiled. This reapplying the first fix, and combining it with the second fix should do the trick. Found this while trying to clear the warning: ``` tests/unit/Makefile.am:402: warning: variable 'init_script_test_helper_SOURCES' is defined but no program or tests/unit/Makefile.am:402: library has 'init_script_test_helper' as canonical name (possible typo) ``` This reverts commit ebd97bd.
I don't know why, but this was necessary, and all the other tests does this. I was getting the following errors after enabling subdir-objects in `AM_INIT_AUTOMAKE`: ``` Makefile:1843: ../../cf-upgrade/.deps/cf_upgrade_test-alloc-mini.Po: No such file or directory Makefile:1844: ../../cf-upgrade/.deps/cf_upgrade_test-command_line.Po: No such file or directory Makefile:1845: ../../cf-upgrade/.deps/cf_upgrade_test-configuration.Po: No such file or directory Makefile:1846: ../../cf-upgrade/.deps/cf_upgrade_test-log.Po: No such file or directory Makefile:1847: ../../cf-upgrade/.deps/cf_upgrade_test-process.Po: No such file or directory Makefile:1848: ../../cf-upgrade/.deps/cf_upgrade_test-update.Po: No such file or directory ``` Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
The `init_script_test_helper` binary does not require any libraries. The libraries `libpromises.la` and `libtest.la` were previously added through the `LDADD` variable in the top of Makefile.am. Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
For some reason it causes the following error ``` 10:58:19 Makefile:598: ../../libpromises/.deps/lastseen.Po: No such file or directory 10:58:19 make[3]: *** No rule to make target '../../libpromises/.deps/lastseen.Po'. Stop. ``` in bootstrap_pr while doing `make dist` in Jenkins. Ticket: CFE-2780 Signed-off-by: Lars Erik Wik <[email protected]>
This reverts commit ba693ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.