Added default:sys.cf_edition variable #5679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ticket: ENT-10078 Signed-off-by: Victor Moene <[email protected]> Changelog: Introduced a new variable default:sys.cf_edition that keeps track whether cfengine is community or enterprise.
victormlg
force-pushed
the
ENT-10078-add-cfedition-variable
branch
from
e4f055d to
81a56e8
Compare
olehermanse
approved these changes
Jan 15, 2025
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11612/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11612/ |
|
@cf-bottom try jenkins again, please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11616/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11616/ |
olehermanse
approved these changes
Jan 16, 2025
| const Class *enterprise_edition = EvalContextClassGet(ctx, "default", "enterprise_edition"); | ||
| if (enterprise_edition == NULL) | ||
| { | ||
| EvalContextVariablePutSpecial(ctx, SPECIAL_SCOPE_SYS, "cf_edition", "community", CF_DATA_TYPE_STRING, "derived-from=enterprise_edition,report"); |
There was a problem hiding this comment.
I see we have one more tag which we typically use for things like this:
Suggested change
| EvalContextVariablePutSpecial(ctx, SPECIAL_SCOPE_SYS, "cf_edition", "community", CF_DATA_TYPE_STRING, "derived-from=enterprise_edition,report"); | |
| EvalContextVariablePutSpecial(ctx, SPECIAL_SCOPE_SYS, "cf_edition", "community", CF_DATA_TYPE_STRING, "derived-from=enterprise_edition,report,source=agent"); |
source=agent means this is defined in the agent (in the C code), as opposed to being defined in the policy.
| } | ||
| else | ||
| { | ||
| EvalContextVariablePutSpecial(ctx, SPECIAL_SCOPE_SYS, "cf_edition", "enterprise", CF_DATA_TYPE_STRING, "derived-from=enterprise_edition,report"); |
There was a problem hiding this comment.
Suggested change
| EvalContextVariablePutSpecial(ctx, SPECIAL_SCOPE_SYS, "cf_edition", "enterprise", CF_DATA_TYPE_STRING, "derived-from=enterprise_edition,report"); | |
| EvalContextVariablePutSpecial(ctx, SPECIAL_SCOPE_SYS, "cf_edition", "enterprise", CF_DATA_TYPE_STRING, "derived-from=enterprise_edition,report,source=agent"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.