Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-4483: Updated syntax description to include new protocol_version values #5681

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

nickanderson
Copy link
Member

This changes the syntax description for the protocol_version attributes to
include the new version 4/filestream protocol. This change is necessary for the
generated documentation to reflect the current state.

Ticket: CFE-4483
Changelog: Title

This changes the syntax description for the protocol_version attributes to
include the new version 4/filestream protocol. This change is necessary for the
generated documentation to reflect the current state.

Ticket: CFE-4483
Changelog: Title
@nickanderson nickanderson requested a review from larsewi January 15, 2025 22:01
@basvandervlies
Copy link
Contributor

Does this also solves this;

07:50 hpcv01p:~/bas/cf_masterfiles/working (update/rm_protocol)
root# cf-agent -IK -f ./update.cf 
/root/bas/cf_masterfiles/working/./lib/update/body.cf:30:28: error: Selection is out of bounds
    protocol_version => "4";
```                           ^

@olehermanse
Copy link
Member

@cf-bottom jenkins, please

@cf-bottom
Copy link

@olehermanse olehermanse self-requested a review January 16, 2025 11:55
@olehermanse olehermanse merged commit f23c912 into cfengine:master Jan 16, 2025
34 of 39 checks passed
@nickanderson
Copy link
Member Author

Does this also solves this;

07:50 hpcv01p:~/bas/cf_masterfiles/working (update/rm_protocol)
root# cf-agent -IK -f ./update.cf 
/root/bas/cf_masterfiles/working/./lib/update/body.cf:30:28: error: Selection is out of bounds
    protocol_version => "4";
```                           ^

Yes, i believe it does:

Prior to the fix:

root@hub:~# cat t.cf
body common control
{
  protocol_version => "4";
}
bundle agent main
{
}


root@hub:~# cf-agent -KIf ./t.cf 
./t.cf:3:26: error: Selection is out of bounds
  protocol_version => "4";
                         ^
   error: There are syntax errors in policy files
   error: Policy failed validation with command '"/var/cfengine/bin/cf-promises" -c "./t.cf"'
   error: Failsafe condition triggered. Interactive session detected, skipping failsafe.cf execution.
   error: Error reading CFEngine policy. Exiting...
root@hub:~# cf-agent --version
CFEngine Core 3.25.0
CFEngine Enterprise 3.25.0

After the fix (using the packages built in the PR):

root@host001:~# cf-agent -KIf ./t.cf 
root@host001:~# cat t.cf 
body common control
{
  protocol_version => "4";
}
bundle agent main
{
}
root@host001:~# cf-agent --version
CFEngine Core 3.26.0a.decd3ad8e
CFEngine Enterprise 3.26.0a.4a27a1555

@nickanderson
Copy link
Member Author

No cherry pick because protocol 4 doesn't exist until 3.25.0 and later and 3.25.0 being a non-lts release there will be no patch versions released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants