Updated install dependencies to include librsync #5684
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
larsewi
commented
Jan 23, 2025
larsewi
commented
- Added ARM64 to regularly build and tested CPU achitectures
- Added librsync to install dependencies
Signed-off-by: Lars Erik Wik <[email protected]>
Only added it to the platforms I've tested. I.e., Debian/Ubuntu, RHEL/CentOS & macOS. Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
commented
Jan 23, 2025
| @@ -54,6 +54,7 @@ CFEngine is regularly built and tested on the following CPU architectures: | |||
| * x86 | |||
There was a problem hiding this comment.
Maybe remove x86? I don't think we build for 32-bit architectures anymore 🤔
There was a problem hiding this comment.
Right. We still build and support i386, aka Windows 32-bit but that is in 3.21.x and 3.24.x so maybe we can change this in master.
craigcomstock
approved these changes
Jan 23, 2025
| @@ -54,6 +54,7 @@ CFEngine is regularly built and tested on the following CPU architectures: | |||
| * x86 | |||
There was a problem hiding this comment.
Right. We still build and support i386, aka Windows 32-bit but that is in 3.21.x and 3.24.x so maybe we can change this in master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.