Added option to print RSYNC performance stats in cf-net #5685
+79
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The truncation of the basis file caused the File Stream API to compute the signature against an empty file, effectively removing all performance benefits from the RSYNC algorithm. Changelog: Title Signed-off-by: Lars Erik Wik <[email protected]>
The performance stats are also logged. This way we can also study the performance through `cf-agent`'s debug logs. The following is an example of running cf-net with the `--stats` option: ``` $ sudo /var/cfengine/bin/cf-net --stats --host 192.168.56.10 get /var/cfengine/masterfiles/promises.cf Send signature statistics: 16970 bytes in (read from 'promises.cf') 2424 bytes out (sent to server) Receive delta statistics: 9 bytes in (received from server) 16970 bytes out (written to 'promises.cf.cfnew') ``` Changelog: Title Signed-off-by: Lars Erik Wik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance stats are also logged unless the
--statsoption is set. This way we can also study the performance through
cf-agent's debug logs.The following is an example of running cf-net with the stats option: