ENT-9402: Added policy to facilitate migration of ignore_interfaces.rx from inputdir to workdir (3.21.x) #2767
Conversation
…utdir to workdir This change aims to increase awareness of the change in behavior for the location of the ignore_interfaces.rx file. It emits reports about the presence and status of the file. In order to further facilitate the migration, this policy will copy the file from inputdir to workdir if the class default:mpf_auto_migrate_ignore_interfaces_rx_to_workdir is defined and the file is present. Ticket: ENT-9402 Changelog: Title (cherry picked from commit 249f380) Signed-off-by: Lars Erik Wik <[email protected]>
|
|
||
| Prior to `3.23.0` this file was expected to be found in | ||
| `$(sys.inputdir)/ignore_interfaces.rx`. Beginning with `3.23.0` preference is | ||
| given to `$(sys.workdir)/ignore_interfaces.rx` if it is found and `WARNING` is |
There was a problem hiding this comment.
| given to `$(sys.workdir)/ignore_interfaces.rx` if it is found and `WARNING` is | |
| given to `$(sys.workdir)/ignore_interfaces.rx`. A `WARNING` is |
There was a problem hiding this comment.
Ah, seeing the policy below I see that it is both a WARNING and a report. Maybe mention the report here as well?
| given to `$(sys.workdir)/ignore_interfaces.rx` if it is found and `WARNING` is | ||
| emitted by cfengine if the file is found only in `$(sys.inputdir)`. | ||
|
|
||
| When the class `default:mpf_auto_migrate_ignore_interfaces_rx_to_workdir` is |
There was a problem hiding this comment.
Is the default to NOT auto migrate? Might be good to mention that as well here.
| { | ||
| "classes": { | ||
| "default:mpf_auto_migrate_ignore_interfaces_rx_to_workdir": { | ||
| "class_expressions": "cfengine_3_23|cfengine_3_24", |
There was a problem hiding this comment.
It would seem most useful to define a class_expression that specified 3.23.0 and later releases right? Hmm.
| # The preferred location for ignore_interfaces.rx changed from | ||
| # $(sys.inputdir)/ignore_interfaces.rx to $(sys.workdir)/ignore_interfaces.rx in | ||
| # 3.23.0, versions lower than 3.23.0 only look for the file in inputdir and | ||
| # messages relating to the preferred location change are irrelevant. |
There was a problem hiding this comment.
Not sure what this "and messages relating..." sentence is talking about? If the messages are irrelevant why are we keeping them? Are we keeping them?
| # inputdir and emits messages about its presence. Additionally, the file is | ||
| # automatically copied if the file is present in inputdir and the class | ||
| # default:mpf_auto_migrate_ignore_interfaces_rx_to_workdir is defined (not | ||
| # defined by default). |
There was a problem hiding this comment.
there we go, it is not defined by default, which is what I assumed but I think you should explicitly state that in the md file above.
| # defined by default). | ||
| { | ||
| meta: | ||
| "tags" slist => { "cfengine_recommends" }; |
There was a problem hiding this comment.
what impact does this have? Do we use this somewhere or have used it previously? Interesting, just in this file I guess. @nickanderson was there a plan to leverage this tag somehow? More curious than anything.
There was a problem hiding this comment.
While testing last night I found that it wasn't working, it was searching for the wrong tag. So, it should have been used but was not.
| " policy input directory so that it's easier to", | ||
| " ignore different interfaces on different hosts."); | ||
|
|
||
| default:cfengine_3:: |
There was a problem hiding this comment.
why cfengine_3 here? Is ignore_interfaces.rx only in version >=3? Not that we do much with version <3.
|
Superseded by #2768 |
No description provided.