ENT-12531: Allowed images from raw.github.com #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README files in build module repos often contain images, sometimes those images are served from raw.github.com. This change allows those images to be displayed within the Build app in Mission Portal. Ticket: ENT-12531 Changelog: Title
| @@ -215,7 +215,7 @@ LogLevel warn | |||
| object-src 'none'; \ | |||
| frame-src 'self'; \ | |||
| child-src 'self'; \ | |||
| img-src 'self' data: blob: avatars.githubusercontent.com badges.gitter.im fonts.gstatic.com kiwiirc.com raw.githubusercontent.com; \ | |||
| img-src 'self' data: blob: avatars.githubusercontent.com badges.gitter.im fonts.gstatic.com kiwiirc.com raw.githubusercontent.com raw.github.com; \ | |||
There was a problem hiding this comment.
needed here as well right? https://github.com/cfengine/buildscripts/blob/master/deps-packaging/apache/httpd.conf#L210
There was a problem hiding this comment.
Yep, indeed. here it is. cfengine/buildscripts#1562
craigcomstock
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README files in build module repos often contain images, sometimes those images
are served from raw.github.com. This change allows those images to be displayed
within the Build app in Mission Portal.
Ticket: ENT-12531
Changelog: Title
Merge together: cfengine/buildscripts#1562